draperlaboratory / cbat_tools

Program analysis tools developed at Draper on the CBAT project.
MIT License
102 stars 14 forks source link

Code-refactoring: Move some code in body of Compare.mk_smtlib2_compare to Z3_utils.mk_smtlib2 #295

Open gltrost opened 3 years ago

gltrost commented 3 years ago

Right now, mk_smtlib2 and mk_smtlib2_single act and look very differently, and have very different types. mk_smtlib2 is only ever called inside Compare.mk_smtlib2_compare, where we compute a lot of values and information that should be computed inside mk_smtlib2. Moving this code will make mk_smtlib2 look much more like mk_smtlib2_single.

We should also rename mk_smtlib2 to mk_smtlib2_compare, or something similar.