Fixes detection of intrinsic calls in BAP

draperlaboratory / cbat_tools

Program analysis tools developed at Draper on the CBAT project.

MIT License

101 stars 14 forks source link

Fixes detection of intrinsic calls in BAP #367

Closed bmourad01 closed 2 years ago

bmourad01 commented 2 years ago

Addresses #366.

We no longer rely on a BIL lifter being available, but instead look at the subroutine in question since the information is there on whether it is intrinsic or not.

The Sub.intrinsic tag doesn't seem to get populated anywhere, so for now we can check that the subroutine's name is prefixed with intrinsic:.

fortunac commented 2 years ago

The tests in the CI are failing. Some of them return the opposite result from what we expect while others return errors. Do you know what's causing this?

bmourad01 commented 2 years ago

I think it's what we discussed related to the binaries not being lifted correctly. None of these tests are related to detecting intrinsic calls though.