search

drapostolos / rdp4j

Remote Directory Poller for Java
MIT License
46 stars 25 forks source link

Making start()/stop() non-blocking? #3

Closed drapostolos closed 8 years ago

drapostolos commented 9 years ago

What's your opinion about making these methods non-blocking:

DirectoryPollerBuilder::start();
DirectoryPoller::stop();

They are currently (rdp4j-0.0.8) blocking.

drapostolos commented 9 years ago

The above is a non-backward compatible change in behavior. So maybe a better idea is to add new methods instead (and keeping the old methods as is):

DirectoryPollerBuilder::nonblockingStart();
DirectoryPoller::nonBlockingStop();

Comments?

drapostolos commented 9 years ago

A fix for this has now been pushed to master. See commit: 8e9b28c131ee449bb180d68471a126010970190c

Methods are called:

DirectoryPollerBuilder::StartAsync();
DirectoryPoller::StopAsync();
drapostolos commented 8 years ago

Fixed in version 0.2.1