search

drapostolos / rdp4j

Remote Directory Poller for Java
MIT License
46 stars 25 forks source link

why didn't you add 'FtpDirectory' to the library? #6

Closed OhadR closed 9 years ago

OhadR commented 9 years ago

i suggest to add 'impl' package, and put there all implementations, such as FtpDirectory, JavaIoFileAdapter, etc. This way users can use your jar with all built-in impl's.

great work, BTW!!!

drapostolos commented 9 years ago

Thanks for the comment :)

I didn't add the FtpDirectory on purpose, as it depends on the apache commons-net FtpClient and not all users needs this dependency.

However, I have been thinking of adding sub-projects with different real implementations. I will do that as soon as get the time.

/Alex

OhadR commented 9 years ago

BTW, as you show example for FTP, I can share example for SFTP...

drapostolos commented 9 years ago

yes, please share :)

OhadR commented 9 years ago

https://github.com/OhadR/rdp4j-client/tree/master/src/main/java/example/sftp

drapostolos commented 9 years ago

Thanks @OhadR !

Just updated the User Guide with a link to your examples :+1:

drapostolos commented 9 years ago

See: https://github.com/drapostolos/rdp4j/wiki/User-Guide#sftpolleddirectory

OhadR commented 9 years ago

you are welcome, @drapostolos ! you code project is great and helped me a lot. One comment: in your wiki, you wrote (the header): SftPolledDirectory. I'd changed that to SftpPolledDirectory (missing p...)

drapostolos commented 9 years ago

added the missing p.