DirectoryPoller exposed prematurely in BeforeStartEvent

drapostolos / rdp4j

Remote Directory Poller for Java

MIT License

46 stars 25 forks source link

DirectoryPoller exposed prematurely in BeforeStartEvent #9

Closed drapostolos closed 8 years ago

drapostolos commented 9 years ago

It is currently possible to acquire an DirectoryPoller instance prematurely in DirectoryPollerListener.beforeStart(...). Using the DirectoryPoller prematurely may result in a inconsistent state.

The suggested fix is to remove this method BeforeStartEvent.getDirectoryPoller. This is a non backward compatible change. Are there any objections to this?

Is anyone using the above method? If so, how do you use it?

drapostolos commented 9 years ago

Change committed to master.

drapostolos commented 8 years ago

Fixed in version 0.2.1