search

drashland / sinco

Browser Automation and Testing Tool for Deno, written in full TypeScript
https://drash.land/sinco
MIT License
57 stars 3 forks source link

61 add support for custom browser path #62

Closed SnoCold closed 3 years ago

SnoCold commented 3 years ago

Fixes #61

Summary

Other Notes

This pull request addresses the feature of using a chromium/gecko engine based browser, alternative to the currently prevalent Chrome/Firefox. The feature works as long as the browser engines are the same as the Original (Chrome/Firefox) browsers.

SnoCold commented 3 years ago

2 things:

1. Have you tested this with your Brave browser? I'm not confident we should say we support other chromium based browsers because we don't actually test them (yet), so it's unsure if they will actually work - though I might do this in a separate PR to avoid the headache for you (unless you want to), i think it's just a matter of installing brave on the CI workflow and in the dockerfile, then an extra integration test that checks it works when passing in the path to brave

Though, saying that, maybe it isn't needed, maybe the fact we offer the option to use a different path is enough?

1. Ill need to write the docs for this before we can release this feature, or you can as well if you feel like it and are familiar with the frontend/vue :)

  1. Yes I have tested this with Brave Browser. It works seamlessly. Yes we could add Brave browser in the CI flow, but that is going to pile up as and when a new chromium browser comes out. Maybe if someone faces specific issues pertaining their chromiums, then can log an issue (which they most likely won't as they won't be modifying the engine so much that it isn't chromium anymore.)

  2. I am not really familiar with vue. But I would surely like to try, if it is ok with all. I will definitely put it down if really cant get it.

ebebbington commented 3 years ago

Yes I have tested this with Brave Browser. It works seamlessly.

That is perfect :D That is really great news that it just works, i know you mentioned it should just work anyway, but it's nice to see it has done :)

I do see your your point bout point 1 though, I think us saying "We also support other browsers like Brave, you can set the path to do this" is enough

I am not really familiar with vue. But I would surely like to try, if it is ok with all. I will definitely put it down if really cant get it.

Feel free :) It's not a problem if not, we can discuss it on the discord