search

drashland / wocket

A WebSocket library for Deno
MIT License
104 stars 4 forks source link

chore: Update dependencies ad add more tests #76

Closed drashbot closed 3 years ago

drashbot commented 4 years ago

This was auto-generated by GitHub Actions.

ebebbington commented 3 years ago

is this something we want to do at the moment?

crookse commented 3 years ago

yea but let's also fix our implementations in this PR

ebebbington commented 3 years ago

oh yeah they moved the websocket stuff, ill look into it now

ebebbington commented 3 years ago

KEY CHANGES

I felt having a web server was kind of unecessary, as we want to make sure that our socket server can get and receieve messages, whereas before, it was only testing getting messages. So i removed the web server and simplified the tests (using std/ws tests as a guideline too)

Alongside this, the data sent to the ws server was actually incorrect - it was an object like { data: { connect_to: ... }} as the main parent prop, when it shouldn't have the data prop (or at least the server doesn't expect it to)

ebebbington commented 3 years ago

And added extra tests

ebebbington commented 3 years ago

ready for review