Lots of feature improvements and bug fixes

[Batcastle]

Yeah there's a lot here. Just look at the commits

[pep8speaks]

Hello @Batcastle! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file usr/share/system-installer/UI/main.py:

Line 33:1: E402 module level import not at top of file Line 70:80: E501 line too long (113 > 79 characters) Line 72:80: E501 line too long (105 > 79 characters) Line 191:80: E501 line too long (98 > 79 characters) Line 453:80: E501 line too long (84 > 79 characters) Line 636:80: E501 line too long (82 > 79 characters) Line 684:5: E303 too many blank lines (2) Line 760:13: E129 visually indented line with same indent as next logical line Line 761:17: E117 over-indented Line 796:13: E125 continuation line with same indent as next logical line Line 796:80: E501 line too long (87 > 79 characters) Line 797:17: E117 over-indented Line 815:80: E501 line too long (80 > 79 characters) Line 816:14: E126 continuation line over-indented for hanging indent Line 817:17: E117 over-indented Line 834:14: E126 continuation line over-indented for hanging indent Line 835:17: E117 over-indented Line 852:14: E126 continuation line over-indented for hanging indent Line 853:17: E117 over-indented Line 870:14: E126 continuation line over-indented for hanging indent Line 871:14: E126 continuation line over-indented for hanging indent Line 872:17: E117 over-indented Line 890:14: E126 continuation line over-indented for hanging indent Line 891:14: E126 continuation line over-indented for hanging indent Line 892:17: E117 over-indented Line 933:17: E129 visually indented line with same indent as next logical line Line 934:21: E117 over-indented Line 967:80: E501 line too long (81 > 79 characters) Line 1052:80: E501 line too long (83 > 79 characters) Line 1110:32: W503 line break before binary operator Line 1130:13: E129 visually indented line with same indent as next logical line Line 1131:17: E117 over-indented Line 1133:80: E501 line too long (81 > 79 characters) Line 1239:16: E713 test for membership should be 'not in' Line 1251:5: E303 too many blank lines (2) Line 1275:5: E303 too many blank lines (2) Line 1286:13: E124 closing bracket does not match visual indentation Line 1287:13: E124 closing bracket does not match visual indentation Line 1288:13: E124 closing bracket does not match visual indentation Line 1289:13: E124 closing bracket does not match visual indentation Line 1289:13: E125 continuation line with same indent as next logical line Line 1316:80: E501 line too long (80 > 79 characters)

• In the file usr/share/system-installer/UI/success.py:

Line 33:1: E402 module level import not at top of file Line 34:1: E402 module level import not at top of file Line 239:80: E501 line too long (103 > 79 characters) Line 242:80: E501 line too long (86 > 79 characters) Line 246:80: E501 line too long (80 > 79 characters) Line 271:41: E127 continuation line over-indented for visual indent Line 334:80: E501 line too long (88 > 79 characters) Line 336:80: E501 line too long (123 > 79 characters) Line 345:80: E501 line too long (81 > 79 characters) Line 358:80: E501 line too long (97 > 79 characters) Line 372:1: E302 expected 2 blank lines, found 1 Line 384:1: E305 expected 2 blank lines after class or function definition, found 1

• In the file usr/share/system-installer/check_internet.py:

Line 50:1: E302 expected 2 blank lines, found 1

• In the file usr/share/system-installer/engine.py:

Line 82:80: E501 line too long (88 > 79 characters) Line 130:80: E501 line too long (89 > 79 characters)

• In the file usr/share/system-installer/installer.py:

Line 117:80: E501 line too long (86 > 79 characters) Line 189:55: W504 line break after binary operator Line 211:80: E501 line too long (90 > 79 characters) Line 223:80: E501 line too long (90 > 79 characters) Line 242:13: E117 over-indented Line 245:80: E501 line too long (97 > 79 characters) Line 279:80: E501 line too long (81 > 79 characters) Line 283:62: W504 line break after binary operator Line 284:80: E501 line too long (92 > 79 characters) Line 294:52: W504 line break after binary operator

• In the file usr/share/system-installer/modules/install_updates.py:

Line 37:1: E302 expected 2 blank lines, found 1

• In the file usr/share/system-installer/modules/make_swap.py:

Line 33:1: E302 expected 2 blank lines, found 1 Line 69:1: E305 expected 2 blank lines after class or function definition, found 1

• In the file usr/share/system-installer/modules/make_user.py:

Line 47:80: E501 line too long (100 > 79 characters) Line 60:80: E501 line too long (80 > 79 characters) Line 66:80: E501 line too long (80 > 79 characters)

• In the file usr/share/system-installer/modules/master.py:

Line 29:80: E501 line too long (80 > 79 characters) Line 51:1: E302 expected 2 blank lines, found 1 Line 65:1: E302 expected 2 blank lines, found 1 Line 74:80: E501 line too long (85 > 79 characters) Line 142:80: E501 line too long (82 > 79 characters) Line 144:80: E501 line too long (82 > 79 characters) Line 145:80: E501 line too long (82 > 79 characters) Line 191:80: E501 line too long (80 > 79 characters) Line 194:80: E501 line too long (82 > 79 characters) Line 199:1: E302 expected 2 blank lines, found 1 Line 215:1: E302 expected 2 blank lines, found 1 Line 228:80: E501 line too long (90 > 79 characters) Line 235:1: E302 expected 2 blank lines, found 1 Line 254:1: E302 expected 2 blank lines, found 1 Line 267:80: E501 line too long (84 > 79 characters) Line 289:80: E501 line too long (103 > 79 characters) Line 293:80: E501 line too long (114 > 79 characters) Line 299:80: E501 line too long (90 > 79 characters) Line 301:80: E501 line too long (80 > 79 characters) Line 304:80: E501 line too long (85 > 79 characters) Line 321:1: E302 expected 2 blank lines, found 1 Line 335:80: E501 line too long (85 > 79 characters) Line 343:80: E501 line too long (109 > 79 characters) Line 344:80: E501 line too long (109 > 79 characters) Line 352:80: E501 line too long (94 > 79 characters) Line 360:80: E501 line too long (115 > 79 characters) Line 361:80: E501 line too long (119 > 79 characters) Line 418:1: E303 too many blank lines (4) Line 427:80: E501 line too long (86 > 79 characters) Line 430:80: E501 line too long (86 > 79 characters) Line 432:1: E302 expected 2 blank lines, found 1 Line 445:1: E305 expected 2 blank lines after class or function definition, found 1 Line 465:9: E116 unexpected indentation (comment) Line 467:9: E116 unexpected indentation (comment)

• In the file usr/share/system-installer/modules/set_locale.py:

Line 54:80: E501 line too long (82 > 79 characters) Line 73:5: E125 continuation line with same indent as next logical line Line 73:13: E124 closing bracket does not match visual indentation

• In the file usr/share/system-installer/modules/set_wallpaper.py:

Line 60:80: E501 line too long (89 > 79 characters)

• In the file usr/share/system-installer/modules/systemd_boot_config.py:

Line 46:80: E501 line too long (88 > 79 characters) Line 93:80: E501 line too long (138 > 79 characters) Line 117:80: E501 line too long (150 > 79 characters) Line 121:80: E501 line too long (81 > 79 characters) Line 141:80: E501 line too long (81 > 79 characters)

• In the file usr/share/system-installer/modules/verify_install.py:

Line 45:80: E501 line too long (82 > 79 characters)

[Batcastle]

Testing shows bugs, but a working installation. merging. Will fix bugs and merge fixes in later.