Lots of bug fixes and performance improvments

[Batcastle]

Yeah. Lets just leave it at that. Lol

[pep8speaks]

Hello @Batcastle! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file usr/share/system-installer/UI/main.py:

Line 33:1: E402 module level import not at top of file Line 34:1: E402 module level import not at top of file Line 67:80: E501 line too long (80 > 79 characters) Line 69:80: E501 line too long (82 > 79 characters) Line 164:80: E501 line too long (98 > 79 characters) Line 426:80: E501 line too long (84 > 79 characters) Line 585:80: E501 line too long (96 > 79 characters) Line 626:80: E501 line too long (92 > 79 characters) Line 627:80: E501 line too long (94 > 79 characters) Line 628:80: E501 line too long (128 > 79 characters) Line 641:5: E303 too many blank lines (2) Line 685:80: E501 line too long (82 > 79 characters) Line 708:5: E303 too many blank lines (2) Line 740:5: E303 too many blank lines (2) Line 852:80: E501 line too long (91 > 79 characters) Line 870:80: E501 line too long (119 > 79 characters) Line 1021:80: E501 line too long (81 > 79 characters) Line 1106:80: E501 line too long (83 > 79 characters) Line 1164:32: W503 line break before binary operator Line 1290:16: E713 test for membership should be 'not in' Line 1302:5: E303 too many blank lines (2) Line 1326:5: E303 too many blank lines (2) Line 1337:13: E124 closing bracket does not match visual indentation Line 1338:18: E124 closing bracket does not match visual indentation Line 1339:23: E124 closing bracket does not match visual indentation Line 1340:28: E124 closing bracket does not match visual indentation Line 1367:80: E501 line too long (80 > 79 characters) Line 1411:1: E302 expected 2 blank lines, found 1

• In the file usr/share/system-installer/UI/progress.py:

Line 29:1: E402 module level import not at top of file Line 30:1: E402 module level import not at top of file Line 34:1: E302 expected 2 blank lines, found 1 Line 37:5: E115 expected an indented block (comment) Line 59:9: E303 too many blank lines (2) Line 97:5: E303 too many blank lines (2) Line 122:1: E302 expected 2 blank lines, found 1 Line 135:1: E302 expected 2 blank lines, found 1 Line 142:1: E302 expected 2 blank lines, found 1 Line 148:1: E305 expected 2 blank lines after class or function definition, found 1

• In the file usr/share/system-installer/UI/report.py:

Line 37:1: E402 module level import not at top of file Line 280:80: E501 line too long (83 > 79 characters) Line 288:80: E501 line too long (95 > 79 characters) Line 297:13: E722 do not use bare 'except' Line 312:9: E722 do not use bare 'except' Line 316:80: E501 line too long (132 > 79 characters) Line 369:80: E501 line too long (80 > 79 characters) Line 371:63: W504 line break after binary operator Line 375:80: E501 line too long (84 > 79 characters) Line 377:80: E501 line too long (86 > 79 characters) Line 415:80: E501 line too long (94 > 79 characters) Line 416:80: E501 line too long (92 > 79 characters) Line 425:63: W504 line break after binary operator Line 462:80: E501 line too long (94 > 79 characters) Line 463:80: E501 line too long (92 > 79 characters) Line 489:80: E501 line too long (84 > 79 characters) Line 531:80: E501 line too long (80 > 79 characters) Line 602:80: E501 line too long (106 > 79 characters)

• In the file usr/share/system-installer/UI/success.py:

Line 34:1: E402 module level import not at top of file Line 35:1: E402 module level import not at top of file Line 157:16: E111 indentation is not a multiple of four Line 199:20: E128 continuation line under-indented for visual indent Line 240:80: E501 line too long (103 > 79 characters) Line 243:80: E501 line too long (86 > 79 characters) Line 247:80: E501 line too long (80 > 79 characters) Line 272:41: E127 continuation line over-indented for visual indent Line 279:80: E501 line too long (83 > 79 characters) Line 321:80: E501 line too long (93 > 79 characters) Line 322:80: E501 line too long (93 > 79 characters) Line 326:80: E501 line too long (94 > 79 characters) Line 330:80: E501 line too long (94 > 79 characters) Line 337:80: E501 line too long (99 > 79 characters) Line 355:80: E501 line too long (81 > 79 characters) Line 369:80: E501 line too long (97 > 79 characters) Line 383:1: E302 expected 2 blank lines, found 1 Line 395:1: E305 expected 2 blank lines after class or function definition, found 1

• In the file usr/share/system-installer/auto_partitioner.py:

Line 126:80: E501 line too long (87 > 79 characters) Line 129:80: E501 line too long (85 > 79 characters) Line 131:80: E501 line too long (95 > 79 characters) Line 133:80: E501 line too long (85 > 79 characters) Line 136:80: E501 line too long (83 > 79 characters) Line 137:80: E501 line too long (81 > 79 characters) Line 139:80: E501 line too long (81 > 79 characters) Line 146:80: E501 line too long (80 > 79 characters) Line 148:80: E501 line too long (87 > 79 characters) Line 185:80: E501 line too long (99 > 79 characters) Line 187:80: E501 line too long (87 > 79 characters) Line 190:80: E501 line too long (85 > 79 characters) Line 192:80: E501 line too long (95 > 79 characters) Line 194:80: E501 line too long (85 > 79 characters) Line 196:80: E501 line too long (83 > 79 characters) Line 197:80: E501 line too long (82 > 79 characters) Line 199:80: E501 line too long (82 > 79 characters) Line 207:80: E501 line too long (86 > 79 characters) Line 208:80: E501 line too long (82 > 79 characters) Line 210:80: E501 line too long (87 > 79 characters) Line 277:80: E501 line too long (93 > 79 characters) Line 278:80: E501 line too long (80 > 79 characters) Line 279:80: E501 line too long (81 > 79 characters) Line 361:80: E501 line too long (85 > 79 characters) Line 397:80: E501 line too long (92 > 79 characters) Line 398:80: E501 line too long (100 > 79 characters) Line 412:80: E501 line too long (80 > 79 characters)

• In the file usr/share/system-installer/check_kernel_versions.py:

Line 36:80: E501 line too long (80 > 79 characters) Line 38:80: E501 line too long (80 > 79 characters) Line 78:80: E501 line too long (92 > 79 characters) Line 79:80: E501 line too long (93 > 79 characters)

• In the file usr/share/system-installer/engine.py:

Line 85:80: E501 line too long (95 > 79 characters) Line 133:80: E501 line too long (89 > 79 characters)

• In the file usr/share/system-installer/installer.py:

Line 113:80: E501 line too long (82 > 79 characters) Line 174:14: E128 continuation line under-indented for visual indent Line 196:80: E501 line too long (86 > 79 characters) Line 200:80: E501 line too long (81 > 79 characters) Line 216:80: E501 line too long (90 > 79 characters) Line 221:80: E501 line too long (86 > 79 characters) Line 228:80: E501 line too long (90 > 79 characters) Line 245:14: E128 continuation line under-indented for visual indent Line 250:80: E501 line too long (93 > 79 characters) Line 252:22: E128 continuation line under-indented for visual indent Line 254:22: E128 continuation line under-indented for visual indent Line 258:26: E128 continuation line under-indented for visual indent Line 280:80: E501 line too long (85 > 79 characters) Line 282:18: E128 continuation line under-indented for visual indent Line 295:80: E501 line too long (86 > 79 characters) Line 296:80: E501 line too long (92 > 79 characters) Line 297:80: E501 line too long (85 > 79 characters) Line 298:18: E128 continuation line under-indented for visual indent Line 305:59: W504 line break after binary operator Line 306:16: E128 continuation line under-indented for visual indent

• In the file usr/share/system-installer/modules/auto_login_set.py:

Line 29:1: E302 expected 2 blank lines, found 1 Line 65:1: E305 expected 2 blank lines after class or function definition, found 1

• In the file usr/share/system-installer/modules/install_extras.py:

Line 51:80: E501 line too long (80 > 79 characters) Line 56:80: E501 line too long (93 > 79 characters) Line 59:80: E501 line too long (128 > 79 characters) Line 91:80: E501 line too long (102 > 79 characters) Line 92:80: E501 line too long (86 > 79 characters)

• In the file usr/share/system-installer/modules/make_swap.py:

Line 33:1: E302 expected 2 blank lines, found 1 Line 69:1: E305 expected 2 blank lines after class or function definition, found 1

• In the file usr/share/system-installer/modules/make_user.py:

Line 48:80: E501 line too long (100 > 79 characters) Line 66:80: E501 line too long (80 > 79 characters) Line 72:80: E501 line too long (80 > 79 characters)

• In the file usr/share/system-installer/modules/master.py:

Line 53:1: E302 expected 2 blank lines, found 1 Line 67:1: E302 expected 2 blank lines, found 1 Line 184:16: E128 continuation line under-indented for visual indent Line 192:80: E501 line too long (83 > 79 characters) Line 195:80: E501 line too long (82 > 79 characters) Line 200:1: E302 expected 2 blank lines, found 1 Line 203:12: E128 continuation line under-indented for visual indent Line 204:12: E128 continuation line under-indented for visual indent Line 205:12: E128 continuation line under-indented for visual indent Line 206:12: E128 continuation line under-indented for visual indent Line 207:12: E128 continuation line under-indented for visual indent Line 208:12: E128 continuation line under-indented for visual indent Line 209:11: E128 continuation line under-indented for visual indent Line 218:1: E302 expected 2 blank lines, found 1 Line 245:1: E302 expected 2 blank lines, found 1 Line 263:16: E128 continuation line under-indented for visual indent Line 265:1: E302 expected 2 blank lines, found 1 Line 316:80: E501 line too long (80 > 79 characters) Line 331:16: E128 continuation line under-indented for visual indent Line 337:1: E302 expected 2 blank lines, found 1 Line 344:26: E128 continuation line under-indented for visual indent Line 351:80: E501 line too long (85 > 79 characters) Line 359:80: E501 line too long (127 > 79 characters) Line 360:80: E501 line too long (109 > 79 characters) Line 368:80: E501 line too long (94 > 79 characters) Line 376:80: E501 line too long (131 > 79 characters) Line 377:80: E501 line too long (119 > 79 characters) Line 431:1: E302 expected 2 blank lines, found 1 Line 447:80: E501 line too long (102 > 79 characters) Line 453:80: E501 line too long (102 > 79 characters) Line 471:1: E305 expected 2 blank lines after class or function definition, found 1

• In the file usr/share/system-installer/modules/set_locale.py:

Line 54:80: E501 line too long (82 > 79 characters) Line 73:5: E125 continuation line with same indent as next logical line Line 73:13: E124 closing bracket does not match visual indentation

• In the file usr/share/system-installer/modules/set_time.py:

Line 46:1: E303 too many blank lines (3)

• In the file usr/share/system-installer/modules/systemd_boot_config.py:

Line 46:80: E501 line too long (87 > 79 characters) Line 93:80: E501 line too long (151 > 79 characters) Line 117:80: E501 line too long (163 > 79 characters) Line 121:80: E501 line too long (82 > 79 characters) Line 141:80: E501 line too long (81 > 79 characters)

• In the file usr/share/system-installer/modules/verify_install.py:

Line 45:80: E501 line too long (82 > 79 characters)

[Batcastle]

All the above will be handled later during a mass-refactoring.