Closed theDrake closed 3 years ago
Hello @theDrake! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
usr/share/system-installer/UI/main.py
:Line 33:1: E402 module level import not at top of file Line 34:1: E402 module level import not at top of file Line 67:80: E501 line too long (80 > 79 characters) Line 69:80: E501 line too long (82 > 79 characters) Line 164:80: E501 line too long (98 > 79 characters) Line 426:80: E501 line too long (84 > 79 characters) Line 464:80: E501 line too long (80 > 79 characters) Line 585:80: E501 line too long (96 > 79 characters) Line 626:80: E501 line too long (92 > 79 characters) Line 627:80: E501 line too long (94 > 79 characters) Line 628:80: E501 line too long (128 > 79 characters) Line 641:5: E303 too many blank lines (2) Line 685:80: E501 line too long (82 > 79 characters) Line 708:5: E303 too many blank lines (2) Line 740:5: E303 too many blank lines (2) Line 852:80: E501 line too long (91 > 79 characters) Line 870:80: E501 line too long (119 > 79 characters) Line 1021:80: E501 line too long (81 > 79 characters) Line 1106:80: E501 line too long (83 > 79 characters) Line 1164:32: W503 line break before binary operator Line 1290:16: E713 test for membership should be 'not in' Line 1302:5: E303 too many blank lines (2) Line 1326:5: E303 too many blank lines (2) Line 1337:13: E124 closing bracket does not match visual indentation Line 1338:18: E124 closing bracket does not match visual indentation Line 1339:23: E124 closing bracket does not match visual indentation Line 1340:28: E124 closing bracket does not match visual indentation Line 1367:80: E501 line too long (80 > 79 characters) Line 1411:1: E302 expected 2 blank lines, found 1
FYI, it appears that all of the issues mentioned by pep8speaks were already present prior to my changes.
Please do not merge into the master
branch. Please merge into the dev
branch so that changes are reflected everywhere.
PR has not been moved to dev
branch as requested. No response was made. Closing PR. To reattempt this merge, please rebase to the dev
branch and open a new PR onto said dev
branch.
Fixed a few English typos I noticed. Also changed "complete any of the below segments in any order" to "complete the segments below in any order" as I feel that improves clarity and concision.