Closed Batcastle closed 3 years ago
Hello @Batcastle! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
usr/share/system-installer/UI/common.py
Line 1:3: E226 missing whitespace around arithmetic operator Line 1:13: W292 no newline at end of file
usr/share/system-installer/UI/confirm.py
Line 29:1: E402 module level import not at top of file Line 88:21: E122 continuation line missing indentation or outdented
usr/share/system-installer/UI/main.py
Line 33:1: E402 module level import not at top of file Line 34:1: E402 module level import not at top of file Line 65:80: E501 line too long (80 > 79 characters) Line 67:80: E501 line too long (82 > 79 characters) Line 121:80: E501 line too long (80 > 79 characters) Line 131:80: E501 line too long (80 > 79 characters) Line 134:80: E501 line too long (80 > 79 characters) Line 137:80: E501 line too long (83 > 79 characters) Line 164:80: E501 line too long (98 > 79 characters) Line 477:80: E501 line too long (84 > 79 characters) Line 518:80: E501 line too long (80 > 79 characters) Line 559:80: E501 line too long (82 > 79 characters) Line 585:80: E501 line too long (84 > 79 characters) Line 668:80: E501 line too long (85 > 79 characters) Line 684:80: E501 line too long (80 > 79 characters) Line 716:80: E501 line too long (80 > 79 characters) Line 725:80: E501 line too long (91 > 79 characters) Line 799:80: E501 line too long (85 > 79 characters) Line 806:80: E501 line too long (81 > 79 characters) Line 812:80: E501 line too long (90 > 79 characters) Line 822:80: E501 line too long (98 > 79 characters) Line 845:80: E501 line too long (85 > 79 characters) Line 866:80: E501 line too long (96 > 79 characters) Line 913:80: E501 line too long (92 > 79 characters) Line 914:80: E501 line too long (94 > 79 characters) Line 915:80: E501 line too long (128 > 79 characters) Line 928:5: E303 too many blank lines (2) Line 951:80: E501 line too long (90 > 79 characters) Line 969:80: E501 line too long (82 > 79 characters) Line 998:5: E303 too many blank lines (2) Line 1031:5: E303 too many blank lines (2) Line 1159:80: E501 line too long (94 > 79 characters) Line 1178:80: E501 line too long (125 > 79 characters) Line 1337:80: E501 line too long (81 > 79 characters) Line 1421:80: E501 line too long (83 > 79 characters) Line 1487:32: E128 continuation line under-indented for visual indent Line 1487:32: W503 line break before binary operator Line 1511:80: E501 line too long (93 > 79 characters) Line 1611:5: E303 too many blank lines (2) Line 1635:5: E303 too many blank lines (2) Line 1646:13: E124 closing bracket does not match visual indentation Line 1647:18: E124 closing bracket does not match visual indentation Line 1648:23: E124 closing bracket does not match visual indentation Line 1649:28: E124 closing bracket does not match visual indentation
usr/share/system-installer/UI/progress.py
Line 30:1: E402 module level import not at top of file Line 31:1: E402 module level import not at top of file Line 111:5: E303 too many blank lines (2)
usr/share/system-installer/UI/report.py
Line 37:1: E402 module level import not at top of file Line 306:9: E722 do not use bare 'except' Line 312:80: E501 line too long (84 > 79 characters) Line 320:80: E501 line too long (95 > 79 characters) Line 341:9: E722 do not use bare 'except' Line 345:80: E501 line too long (132 > 79 characters) Line 404:80: E501 line too long (80 > 79 characters) Line 406:80: E501 line too long (81 > 79 characters) Line 409:80: E501 line too long (84 > 79 characters) Line 411:80: E501 line too long (86 > 79 characters) Line 449:80: E501 line too long (94 > 79 characters) Line 450:80: E501 line too long (92 > 79 characters) Line 459:63: W504 line break after binary operator Line 496:80: E501 line too long (94 > 79 characters) Line 497:80: E501 line too long (92 > 79 characters) Line 523:80: E501 line too long (84 > 79 characters) Line 526:80: E501 line too long (84 > 79 characters) Line 572:80: E501 line too long (80 > 79 characters) Line 652:80: E501 line too long (106 > 79 characters)
usr/share/system-installer/UI/success.py
Line 34:1: E402 module level import not at top of file Line 82:80: E501 line too long (89 > 79 characters) Line 204:16: E111 indentation is not a multiple of four Line 252:20: E128 continuation line under-indented for visual indent Line 296:80: E501 line too long (103 > 79 characters) Line 300:80: E501 line too long (86 > 79 characters) Line 305:80: E501 line too long (80 > 79 characters) Line 335:41: E127 continuation line over-indented for visual indent Line 342:80: E501 line too long (83 > 79 characters) Line 384:80: E501 line too long (93 > 79 characters) Line 385:80: E501 line too long (93 > 79 characters) Line 389:80: E501 line too long (94 > 79 characters) Line 393:80: E501 line too long (94 > 79 characters) Line 400:80: E501 line too long (99 > 79 characters) Line 418:80: E501 line too long (81 > 79 characters) Line 432:80: E501 line too long (97 > 79 characters) Line 446:1: E302 expected 2 blank lines, found 1
usr/share/system-installer/auto_partitioner.py
Line 126:80: E501 line too long (87 > 79 characters) Line 129:80: E501 line too long (85 > 79 characters) Line 131:80: E501 line too long (95 > 79 characters) Line 133:80: E501 line too long (85 > 79 characters) Line 136:80: E501 line too long (83 > 79 characters) Line 137:80: E501 line too long (81 > 79 characters) Line 139:80: E501 line too long (81 > 79 characters) Line 146:80: E501 line too long (80 > 79 characters) Line 148:80: E501 line too long (87 > 79 characters) Line 185:80: E501 line too long (99 > 79 characters) Line 187:80: E501 line too long (87 > 79 characters) Line 190:80: E501 line too long (85 > 79 characters) Line 192:80: E501 line too long (95 > 79 characters) Line 194:80: E501 line too long (85 > 79 characters) Line 196:80: E501 line too long (83 > 79 characters) Line 197:80: E501 line too long (82 > 79 characters) Line 199:80: E501 line too long (82 > 79 characters) Line 207:80: E501 line too long (86 > 79 characters) Line 208:80: E501 line too long (82 > 79 characters) Line 210:80: E501 line too long (87 > 79 characters) Line 286:80: E501 line too long (93 > 79 characters) Line 287:80: E501 line too long (80 > 79 characters) Line 288:80: E501 line too long (81 > 79 characters) Line 330:80: E501 line too long (80 > 79 characters) Line 399:80: E501 line too long (85 > 79 characters) Line 434:80: E501 line too long (92 > 79 characters) Line 435:80: E501 line too long (100 > 79 characters) Line 449:80: E501 line too long (80 > 79 characters)
usr/share/system-installer/check_kernel_versions.py
Line 36:80: E501 line too long (80 > 79 characters) Line 38:80: E501 line too long (80 > 79 characters) Line 78:80: E501 line too long (92 > 79 characters) Line 79:80: E501 line too long (93 > 79 characters)
usr/share/system-installer/engine.py
Line 119:80: E501 line too long (95 > 79 characters) Line 126:80: E501 line too long (87 > 79 characters) Line 163:80: E501 line too long (100 > 79 characters)
usr/share/system-installer/installer.py
Line 70:80: E501 line too long (86 > 79 characters) Line 71:80: E501 line too long (82 > 79 characters) Line 117:80: E501 line too long (82 > 79 characters) Line 205:80: E501 line too long (81 > 79 characters) Line 221:80: E501 line too long (90 > 79 characters) Line 226:80: E501 line too long (86 > 79 characters) Line 233:80: E501 line too long (90 > 79 characters) Line 255:80: E501 line too long (93 > 79 characters) Line 285:80: E501 line too long (85 > 79 characters) Line 300:80: E501 line too long (86 > 79 characters) Line 301:80: E501 line too long (92 > 79 characters) Line 302:80: E501 line too long (85 > 79 characters) Line 310:59: W504 line break after binary operator
usr/share/system-installer/modules/auto_login_set.py
Line 29:1: E302 expected 2 blank lines, found 1 Line 65:1: E305 expected 2 blank lines after class or function definition, found 1
usr/share/system-installer/modules/master.py
Line 41:1: E303 too many blank lines (3) Line 53:1: E302 expected 2 blank lines, found 1 Line 67:1: E302 expected 2 blank lines, found 1 Line 82:80: E501 line too long (89 > 79 characters) Line 202:80: E501 line too long (83 > 79 characters) Line 205:80: E501 line too long (82 > 79 characters) Line 210:1: E302 expected 2 blank lines, found 1 Line 215:80: E501 line too long (88 > 79 characters) Line 217:80: E501 line too long (89 > 79 characters) Line 218:80: E501 line too long (85 > 79 characters) Line 227:1: E302 expected 2 blank lines, found 1 Line 254:1: E302 expected 2 blank lines, found 1 Line 274:1: E302 expected 2 blank lines, found 1 Line 325:80: E501 line too long (80 > 79 characters) Line 347:1: E302 expected 2 blank lines, found 1 Line 361:80: E501 line too long (85 > 79 characters) Line 369:80: E501 line too long (127 > 79 characters) Line 370:80: E501 line too long (109 > 79 characters) Line 378:80: E501 line too long (94 > 79 characters) Line 386:80: E501 line too long (131 > 79 characters) Line 387:80: E501 line too long (119 > 79 characters) Line 441:1: E302 expected 2 blank lines, found 1 Line 457:80: E501 line too long (81 > 79 characters) Line 460:80: E501 line too long (114 > 79 characters) Line 466:80: E501 line too long (114 > 79 characters) Line 487:1: E305 expected 2 blank lines after class or function definition, found 1
usr/share/system-installer/modules/verify_install.py
Line 45:80: E501 line too long (86 > 79 characters)
usr/share/system-installer/oem/post_install/UI.py
Line 34:1: E402 module level import not at top of file Line 36:1: E402 module level import not at top of file Line 97:80: E501 line too long (80 > 79 characters) Line 217:80: E501 line too long (83 > 79 characters) Line 247:80: E501 line too long (83 > 79 characters) Line 299:32: E128 continuation line under-indented for visual indent Line 299:32: W503 line break before binary operator Line 413:5: E303 too many blank lines (2) Line 466:68: E231 missing whitespace after ',' Line 495:41: E127 continuation line over-indented for visual indent
usr/share/system-installer/oem/post_install/configure/auto_login_set.py
usr/share/system-installer/oem/post_install/configure/set_locale.py
Line 53:80: E501 line too long (82 > 79 characters) Line 72:5: E125 continuation line with same indent as next logical line Line 72:13: E124 closing bracket does not match visual indentation
usr/share/system-installer/oem/post_install/configure/set_time.py
Line 46:1: E303 too many blank lines (3)
usr/share/system-installer/oem/pre_install.py
Line 33:1: E402 module level import not at top of file Line 67:80: E501 line too long (80 > 79 characters) Line 70:80: E501 line too long (80 > 79 characters) Line 73:80: E501 line too long (83 > 79 characters) Line 93:80: E501 line too long (82 > 79 characters) Line 119:80: E501 line too long (84 > 79 characters) Line 192:80: E501 line too long (85 > 79 characters) Line 208:80: E501 line too long (80 > 79 characters) Line 240:80: E501 line too long (80 > 79 characters) Line 249:80: E501 line too long (91 > 79 characters) Line 323:80: E501 line too long (85 > 79 characters) Line 330:80: E501 line too long (81 > 79 characters) Line 336:80: E501 line too long (90 > 79 characters) Line 346:80: E501 line too long (98 > 79 characters) Line 369:80: E501 line too long (85 > 79 characters) Line 396:80: E501 line too long (90 > 79 characters) Line 414:80: E501 line too long (82 > 79 characters) Line 443:5: E303 too many blank lines (2) Line 540:1: E303 too many blank lines (3)
Hello @Batcastle! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
usr/share/system-installer/UI/common.py
:usr/share/system-installer/UI/confirm.py
:usr/share/system-installer/UI/main.py
:usr/share/system-installer/UI/progress.py
:usr/share/system-installer/UI/report.py
:usr/share/system-installer/UI/success.py
:usr/share/system-installer/auto_partitioner.py
:usr/share/system-installer/check_kernel_versions.py
:usr/share/system-installer/engine.py
:usr/share/system-installer/installer.py
:usr/share/system-installer/modules/auto_login_set.py
:usr/share/system-installer/modules/master.py
:usr/share/system-installer/modules/verify_install.py
:usr/share/system-installer/oem/post_install/UI.py
:usr/share/system-installer/oem/post_install/configure/auto_login_set.py
:usr/share/system-installer/oem/post_install/configure/set_locale.py
:usr/share/system-installer/oem/post_install/configure/set_time.py
:usr/share/system-installer/oem/pre_install.py
:Comment last updated at 2021-08-15 22:18:05 UTC