Closed Batcastle closed 3 years ago
Hello @Batcastle! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
usr/share/system-installer/UI/error.py
:Line 28:1: E402 module level import not at top of file Line 29:1: E402 module level import not at top of file
usr/share/system-installer/UI/report.py
:Line 37:1: E402 module level import not at top of file Line 317:9: E722 do not use bare 'except' Line 354:9: E722 do not use bare 'except' Line 422:80: E501 line too long (80 > 79 characters) Line 424:80: E501 line too long (81 > 79 characters) Line 427:80: E501 line too long (84 > 79 characters) Line 429:80: E501 line too long (86 > 79 characters) Line 467:80: E501 line too long (89 > 79 characters) Line 468:80: E501 line too long (87 > 79 characters) Line 470:80: E501 line too long (81 > 79 characters) Line 490:80: E501 line too long (86 > 79 characters) Line 528:80: E501 line too long (89 > 79 characters) Line 529:80: E501 line too long (87 > 79 characters) Line 531:80: E501 line too long (81 > 79 characters) Line 552:80: E501 line too long (84 > 79 characters) Line 555:80: E501 line too long (84 > 79 characters) Line 601:80: E501 line too long (80 > 79 characters) Line 669:80: E501 line too long (80 > 79 characters)
usr/share/system-installer/UI/success.py
:Line 34:1: E402 module level import not at top of file Line 72:80: E501 line too long (90 > 79 characters) Line 292:80: E501 line too long (86 > 79 characters) Line 297:80: E501 line too long (80 > 79 characters) Line 334:80: E501 line too long (83 > 79 characters) Line 376:80: E501 line too long (93 > 79 characters) Line 377:80: E501 line too long (93 > 79 characters) Line 381:80: E501 line too long (94 > 79 characters) Line 385:80: E501 line too long (94 > 79 characters) Line 392:80: E501 line too long (99 > 79 characters) Line 410:80: E501 line too long (81 > 79 characters) Line 424:80: E501 line too long (97 > 79 characters)
usr/share/system-installer/auto_partitioner.py
:Line 115:80: E501 line too long (80 > 79 characters) Line 187:80: E501 line too long (87 > 79 characters) Line 190:80: E501 line too long (85 > 79 characters) Line 192:80: E501 line too long (95 > 79 characters) Line 194:80: E501 line too long (85 > 79 characters) Line 197:80: E501 line too long (83 > 79 characters) Line 209:80: E501 line too long (80 > 79 characters) Line 211:80: E501 line too long (87 > 79 characters) Line 248:80: E501 line too long (99 > 79 characters) Line 250:80: E501 line too long (87 > 79 characters) Line 253:80: E501 line too long (85 > 79 characters) Line 255:80: E501 line too long (95 > 79 characters) Line 257:80: E501 line too long (85 > 79 characters) Line 259:80: E501 line too long (83 > 79 characters) Line 272:80: E501 line too long (86 > 79 characters) Line 273:80: E501 line too long (82 > 79 characters) Line 275:80: E501 line too long (87 > 79 characters) Line 435:80: E501 line too long (80 > 79 characters) Line 504:80: E501 line too long (85 > 79 characters) Line 539:80: E501 line too long (92 > 79 characters) Line 540:80: E501 line too long (100 > 79 characters) Line 554:80: E501 line too long (80 > 79 characters)
several variables and functions where being redefined in child classes when they didn't need to be. That was fixed and not only should it help save memory, but it also makes those scripts slightly smaller.