Closed SenlisO closed 3 years ago
Hello @SenlisO! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
usr/share/system-installer/UI/main.py
:Line 34:1: E402 module level import not at top of file Line 35:1: E402 module level import not at top of file Line 37:1: E302 expected 2 blank lines, found 1 Line 60:80: E501 line too long (80 > 79 characters) Line 62:80: E501 line too long (82 > 79 characters) Line 111:80: E501 line too long (80 > 79 characters) Line 121:80: E501 line too long (80 > 79 characters) Line 124:80: E501 line too long (80 > 79 characters) Line 127:80: E501 line too long (83 > 79 characters) Line 154:80: E501 line too long (98 > 79 characters) Line 467:80: E501 line too long (84 > 79 characters) Line 508:80: E501 line too long (80 > 79 characters) Line 549:80: E501 line too long (82 > 79 characters) Line 575:80: E501 line too long (84 > 79 characters) Line 658:80: E501 line too long (85 > 79 characters) Line 674:80: E501 line too long (80 > 79 characters) Line 706:80: E501 line too long (80 > 79 characters) Line 715:80: E501 line too long (91 > 79 characters) Line 789:80: E501 line too long (85 > 79 characters) Line 796:80: E501 line too long (81 > 79 characters) Line 802:80: E501 line too long (90 > 79 characters) Line 812:80: E501 line too long (98 > 79 characters) Line 835:80: E501 line too long (85 > 79 characters) Line 856:80: E501 line too long (96 > 79 characters) Line 903:80: E501 line too long (92 > 79 characters) Line 904:80: E501 line too long (94 > 79 characters) Line 905:80: E501 line too long (128 > 79 characters) Line 951:5: E303 too many blank lines (2) Line 974:80: E501 line too long (90 > 79 characters) Line 992:80: E501 line too long (82 > 79 characters) Line 1021:5: E303 too many blank lines (2) Line 1054:5: E303 too many blank lines (2) Line 1183:80: E501 line too long (94 > 79 characters) Line 1203:80: E501 line too long (125 > 79 characters) Line 1223:16: E126 continuation line over-indented for hanging indent Line 1224:16: E126 continuation line over-indented for hanging indent Line 1306:80: E501 line too long (86 > 79 characters) Line 1307:80: E501 line too long (117 > 79 characters) Line 1314:80: E501 line too long (116 > 79 characters) Line 1315:80: E501 line too long (129 > 79 characters) Line 1328:80: E501 line too long (129 > 79 characters) Line 1335:80: E501 line too long (128 > 79 characters) Line 1408:80: E501 line too long (81 > 79 characters) Line 1492:80: E501 line too long (83 > 79 characters) Line 1558:32: E128 continuation line under-indented for visual indent Line 1558:32: W503 line break before binary operator Line 1582:80: E501 line too long (93 > 79 characters) Line 1682:5: E303 too many blank lines (2) Line 1706:5: E303 too many blank lines (2) Line 1717:13: E124 closing bracket does not match visual indentation Line 1718:18: E124 closing bracket does not match visual indentation Line 1719:23: E124 closing bracket does not match visual indentation Line 1720:28: E124 closing bracket does not match visual indentation
removed si_utilities files and used common for main.py instead.
Created si_utilities.py that contains eprint function.
Created si_utilities.py symlink into UI folder
Updated UI main.py file to use eprint from si_utilities module.
These changes have been tested.