Closed Batcastle closed 2 years ago
Hello @Batcastle! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
usr/lib/python3/dist-packages/de_control/disable.py
:usr/lib/python3/dist-packages/de_control/enable.py
:usr/lib/python3/dist-packages/de_control/modify.py
:Line 43:80: E501 line too long (110 > 79 characters) Line 49:80: E501 line too long (110 > 79 characters)
usr/share/system-installer/UI/confirm.py
:Line 29:1: E402 module level import not at top of file Line 80:21: E128 continuation line under-indented for visual indent Line 81:21: E128 continuation line under-indented for visual indent Line 88:21: E128 continuation line under-indented for visual indent Line 100:21: E128 continuation line under-indented for visual indent Line 105:41: E231 missing whitespace after ','
usr/share/system-installer/UI/error.py
:Line 28:1: E402 module level import not at top of file Line 29:1: E402 module level import not at top of file
usr/share/system-installer/UI/main.py
:Line 37:1: E402 module level import not at top of file Line 43:1: E303 too many blank lines (5) Line 66:80: E501 line too long (80 > 79 characters) Line 68:80: E501 line too long (82 > 79 characters) Line 117:80: E501 line too long (80 > 79 characters) Line 127:80: E501 line too long (80 > 79 characters) Line 130:80: E501 line too long (80 > 79 characters) Line 133:80: E501 line too long (83 > 79 characters) Line 160:80: E501 line too long (98 > 79 characters) Line 473:80: E501 line too long (84 > 79 characters) Line 514:80: E501 line too long (80 > 79 characters) Line 554:80: E501 line too long (89 > 79 characters) Line 555:49: E128 continuation line under-indented for visual indent Line 555:80: E501 line too long (82 > 79 characters) Line 581:80: E501 line too long (84 > 79 characters) Line 664:80: E501 line too long (85 > 79 characters) Line 680:80: E501 line too long (80 > 79 characters) Line 712:80: E501 line too long (80 > 79 characters) Line 721:80: E501 line too long (91 > 79 characters) Line 795:80: E501 line too long (85 > 79 characters) Line 802:80: E501 line too long (81 > 79 characters) Line 808:80: E501 line too long (90 > 79 characters) Line 818:80: E501 line too long (98 > 79 characters) Line 841:80: E501 line too long (85 > 79 characters) Line 862:80: E501 line too long (96 > 79 characters) Line 909:80: E501 line too long (92 > 79 characters) Line 910:45: E128 continuation line under-indented for visual indent Line 911:45: E126 continuation line over-indented for hanging indent Line 911:80: E501 line too long (94 > 79 characters) Line 957:5: E303 too many blank lines (2) Line 979:30: E261 at least two spaces before inline comment Line 979:80: E501 line too long (90 > 79 characters) Line 982:13: E303 too many blank lines (2) Line 983:36: E261 at least two spaces before inline comment Line 983:80: E501 line too long (106 > 79 characters) Line 985:37: E261 at least two spaces before inline comment Line 989:60: E261 at least two spaces before inline comment Line 989:80: E501 line too long (97 > 79 characters) Line 990:41: W291 trailing whitespace Line 992:49: E203 whitespace before ':' Line 992:73: E203 whitespace before ':' Line 992:80: E501 line too long (89 > 79 characters) Line 994:63: E261 at least two spaces before inline comment Line 994:80: E501 line too long (114 > 79 characters) Line 996:55: E261 at least two spaces before inline comment Line 996:80: E501 line too long (92 > 79 characters) Line 999:45: E203 whitespace before ':' Line 999:70: E203 whitespace before ':' Line 999:80: E501 line too long (87 > 79 characters) Line 1003:25: E261 at least two spaces before inline comment Line 1003:80: E501 line too long (86 > 79 characters) Line 1011:80: E501 line too long (103 > 79 characters) Line 1035:5: E303 too many blank lines (2) Line 1068:5: E303 too many blank lines (2) Line 1068:58: E251 unexpected spaces around keyword / parameter equals Line 1068:60: E251 unexpected spaces around keyword / parameter equals Line 1072:80: E501 line too long (88 > 79 characters) Line 1096:5: E303 too many blank lines (2) Line 1190:80: E501 line too long (83 > 79 characters) Line 1200:80: E501 line too long (94 > 79 characters) Line 1212:80: E501 line too long (83 > 79 characters) Line 1214:80: E501 line too long (91 > 79 characters) Line 1224:16: E126 continuation line over-indented for hanging indent Line 1225:16: E126 continuation line over-indented for hanging indent Line 1227:80: E501 line too long (94 > 79 characters) Line 1239:80: E501 line too long (87 > 79 characters) Line 1263:80: E501 line too long (86 > 79 characters) Line 1272:80: E501 line too long (86 > 79 characters) Line 1276:9: E122 continuation line missing indentation or outdented Line 1276:80: E501 line too long (121 > 79 characters) Line 1277:80: E501 line too long (129 > 79 characters) Line 1290:80: E501 line too long (80 > 79 characters) Line 1291:80: E501 line too long (154 > 79 characters) Line 1329:80: E501 line too long (89 > 79 characters) Line 1355:80: E501 line too long (81 > 79 characters) Line 1439:80: E501 line too long (83 > 79 characters) Line 1505:32: E128 continuation line under-indented for visual indent Line 1505:32: W503 line break before binary operator Line 1529:80: E501 line too long (93 > 79 characters) Line 1629:5: E303 too many blank lines (2) Line 1653:5: E303 too many blank lines (2) Line 1664:13: E124 closing bracket does not match visual indentation Line 1665:18: E124 closing bracket does not match visual indentation Line 1666:23: E124 closing bracket does not match visual indentation Line 1667:28: E124 closing bracket does not match visual indentation
usr/share/system-installer/UI/progress.py
:Line 30:1: E402 module level import not at top of file Line 31:1: E402 module level import not at top of file Line 111:5: E303 too many blank lines (2)
usr/share/system-installer/UI/report.py
:Line 37:1: E402 module level import not at top of file Line 317:9: E722 do not use bare 'except' Line 354:9: E722 do not use bare 'except' Line 425:80: E501 line too long (98 > 79 characters) Line 427:80: E501 line too long (98 > 79 characters) Line 454:80: E501 line too long (81 > 79 characters) Line 480:80: E501 line too long (80 > 79 characters) Line 483:80: E501 line too long (80 > 79 characters) Line 529:80: E501 line too long (80 > 79 characters) Line 597:80: E501 line too long (80 > 79 characters) Line 678:80: E501 line too long (81 > 79 characters)
usr/share/system-installer/UI/success.py
:Line 34:1: E402 module level import not at top of file Line 75:80: E501 line too long (90 > 79 characters) Line 295:80: E501 line too long (86 > 79 characters) Line 300:80: E501 line too long (80 > 79 characters) Line 337:80: E501 line too long (83 > 79 characters) Line 379:80: E501 line too long (93 > 79 characters) Line 380:80: E501 line too long (93 > 79 characters) Line 384:80: E501 line too long (94 > 79 characters) Line 388:80: E501 line too long (94 > 79 characters) Line 395:80: E501 line too long (99 > 79 characters) Line 413:80: E501 line too long (81 > 79 characters) Line 427:80: E501 line too long (97 > 79 characters)
usr/share/system-installer/auto_partitioner.py
:Line 115:80: E501 line too long (80 > 79 characters) Line 187:80: E501 line too long (87 > 79 characters) Line 190:80: E501 line too long (85 > 79 characters) Line 192:80: E501 line too long (95 > 79 characters) Line 194:80: E501 line too long (85 > 79 characters) Line 197:80: E501 line too long (83 > 79 characters) Line 209:80: E501 line too long (80 > 79 characters) Line 211:80: E501 line too long (87 > 79 characters) Line 248:80: E501 line too long (99 > 79 characters) Line 250:80: E501 line too long (87 > 79 characters) Line 253:80: E501 line too long (85 > 79 characters) Line 255:80: E501 line too long (95 > 79 characters) Line 257:80: E501 line too long (85 > 79 characters) Line 259:80: E501 line too long (83 > 79 characters) Line 272:80: E501 line too long (86 > 79 characters) Line 273:80: E501 line too long (82 > 79 characters) Line 275:80: E501 line too long (87 > 79 characters) Line 435:80: E501 line too long (80 > 79 characters) Line 504:80: E501 line too long (85 > 79 characters) Line 539:80: E501 line too long (92 > 79 characters) Line 540:80: E501 line too long (100 > 79 characters) Line 554:80: E501 line too long (80 > 79 characters)
usr/share/system-installer/check_kernel_versions.py
:Line 38:80: E501 line too long (84 > 79 characters) Line 40:80: E501 line too long (84 > 79 characters) Line 87:80: E501 line too long (92 > 79 characters) Line 88:80: E501 line too long (93 > 79 characters)
usr/share/system-installer/engine.py
:Line 105:80: E501 line too long (81 > 79 characters) Line 110:80: E501 line too long (82 > 79 characters) Line 112:80: E501 line too long (80 > 79 characters) Line 113:30: E128 continuation line under-indented for visual indent Line 114:80: E501 line too long (95 > 79 characters) Line 121:80: E501 line too long (87 > 79 characters) Line 142:22: E128 continuation line under-indented for visual indent Line 150:22: E128 continuation line under-indented for visual indent Line 152:80: E501 line too long (100 > 79 characters)
usr/share/system-installer/installer.py
:Line 70:80: E501 line too long (86 > 79 characters) Line 71:80: E501 line too long (82 > 79 characters) Line 122:80: E501 line too long (82 > 79 characters) Line 179:13: E128 continuation line under-indented for visual indent Line 200:80: E501 line too long (84 > 79 characters) Line 201:80: E501 line too long (83 > 79 characters) Line 211:80: E501 line too long (81 > 79 characters) Line 227:80: E501 line too long (90 > 79 characters) Line 232:80: E501 line too long (86 > 79 characters) Line 239:80: E501 line too long (90 > 79 characters) Line 257:80: E501 line too long (96 > 79 characters) Line 277:80: E501 line too long (86 > 79 characters) Line 278:80: E501 line too long (92 > 79 characters) Line 281:59: W504 line break after binary operator
usr/share/system-installer/modules/auto_login_set.py
:Line 29:1: E302 expected 2 blank lines, found 1 Line 65:1: E305 expected 2 blank lines after class or function definition, found 1
usr/share/system-installer/modules/install_extras.py
:Line 51:80: E501 line too long (80 > 79 characters) Line 56:80: E501 line too long (93 > 79 characters) Line 59:80: E501 line too long (128 > 79 characters) Line 96:80: E501 line too long (102 > 79 characters) Line 97:80: E501 line too long (86 > 79 characters)
usr/share/system-installer/modules/make_swap.py
:Line 32:1: E302 expected 2 blank lines, found 1 Line 64:1: E305 expected 2 blank lines after class or function definition, found 1
usr/share/system-installer/modules/make_user.py
:Line 48:80: E501 line too long (100 > 79 characters) Line 66:80: E501 line too long (80 > 79 characters) Line 72:80: E501 line too long (80 > 79 characters)
usr/share/system-installer/modules/master.py
:Line 204:80: E501 line too long (83 > 79 characters) Line 207:80: E501 line too long (82 > 79 characters) Line 218:80: E501 line too long (88 > 79 characters) Line 222:80: E501 line too long (85 > 79 characters) Line 274:32: E127 continuation line over-indented for visual indent Line 282:36: E127 continuation line over-indented for visual indent Line 299:35: E202 whitespace before ')' Line 343:80: E501 line too long (80 > 79 characters) Line 346:80: E501 line too long (87 > 79 characters) Line 352:80: E501 line too long (81 > 79 characters) Line 417:80: E501 line too long (127 > 79 characters) Line 418:80: E501 line too long (109 > 79 characters) Line 435:80: E501 line too long (131 > 79 characters) Line 436:80: E501 line too long (119 > 79 characters)
usr/share/system-installer/modules/set_locale.py
:Line 53:80: E501 line too long (82 > 79 characters) Line 72:5: E125 continuation line with same indent as next logical line Line 72:13: E124 closing bracket does not match visual indentation
usr/share/system-installer/modules/set_time.py
:usr/share/system-installer/modules/verify_install.py
:Line 50:47: W605 invalid escape sequence '\E' Line 50:51: W605 invalid escape sequence '\s' Line 50:59: W605 invalid escape sequence '\s' Line 50:80: E501 line too long (80 > 79 characters) Line 102:80: E501 line too long (87 > 79 characters) Line 125:80: E501 line too long (86 > 79 characters)
usr/share/system-installer/oem/post_install/UI.py
:Line 34:1: E402 module level import not at top of file Line 36:1: E402 module level import not at top of file Line 97:80: E501 line too long (80 > 79 characters) Line 217:80: E501 line too long (83 > 79 characters) Line 247:80: E501 line too long (83 > 79 characters) Line 299:32: E128 continuation line under-indented for visual indent Line 299:32: W503 line break before binary operator Line 413:5: E303 too many blank lines (2) Line 466:68: E231 missing whitespace after ',' Line 495:41: E127 continuation line over-indented for visual indent
Line 29:1: E302 expected 2 blank lines, found 1 Line 65:1: E305 expected 2 blank lines after class or function definition, found 1
Line 53:80: E501 line too long (82 > 79 characters) Line 72:5: E125 continuation line with same indent as next logical line Line 72:13: E124 closing bracket does not match visual indentation
usr/share/system-installer/oem/pre_install.py
:Line 33:1: E402 module level import not at top of file Line 67:80: E501 line too long (80 > 79 characters) Line 70:80: E501 line too long (80 > 79 characters) Line 73:80: E501 line too long (83 > 79 characters) Line 93:80: E501 line too long (82 > 79 characters) Line 119:80: E501 line too long (84 > 79 characters) Line 192:80: E501 line too long (85 > 79 characters) Line 208:80: E501 line too long (80 > 79 characters) Line 240:80: E501 line too long (80 > 79 characters) Line 249:80: E501 line too long (91 > 79 characters) Line 323:80: E501 line too long (85 > 79 characters) Line 330:80: E501 line too long (81 > 79 characters) Line 336:80: E501 line too long (90 > 79 characters) Line 346:80: E501 line too long (98 > 79 characters) Line 369:80: E501 line too long (85 > 79 characters) Line 396:80: E501 line too long (90 > 79 characters) Line 414:80: E501 line too long (82 > 79 characters) Line 443:5: E303 too many blank lines (2) Line 540:1: E303 too many blank lines (3)
Fix #51 thanks to @SenlisO Convert
usr/bin/system-installer
to C++ for better performance and integration with future conversion efforts Update copyright dates to 2022 fix minor build bug