A multitude of bug fixes

[Batcastle]

• improvements for 4K screens
• enable usage of a package pool OR a kernel archive (now deprecated)
• generate change logs when building package
• better branding support
• ensure boot loader is added
• multiple bug fixes for BIOS installations
• initial work on converting to C++
• loads of fixes for auto partitioning
  • had to disable using home partitions on the same drive as the root partition. Please use manual partitioning if this affects you

[pep8speaks]

Hello @Batcastle! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file usr/lib/python3/dist-packages/de_control/disable.py:

Line 27:1: E302 expected 2 blank lines, found 1

• In the file usr/lib/python3/dist-packages/de_control/enable.py:

Line 28:1: E302 expected 2 blank lines, found 1

• In the file usr/lib/python3/dist-packages/de_control/modify.py:

Line 43:80: E501 line too long (110 > 79 characters) Line 49:80: E501 line too long (110 > 79 characters)

• In the file usr/share/system-installer/UI/confirm.py:

Line 29:1: E402 module level import not at top of file Line 80:21: E128 continuation line under-indented for visual indent Line 81:21: E128 continuation line under-indented for visual indent Line 88:21: E128 continuation line under-indented for visual indent Line 100:21: E128 continuation line under-indented for visual indent Line 105:41: E231 missing whitespace after ','

• In the file usr/share/system-installer/UI/error.py:

Line 28:1: E402 module level import not at top of file Line 29:1: E402 module level import not at top of file

• In the file usr/share/system-installer/UI/main.py:

Line 38:1: E402 module level import not at top of file Line 64:80: E501 line too long (80 > 79 characters) Line 66:80: E501 line too long (82 > 79 characters) Line 115:80: E501 line too long (80 > 79 characters) Line 125:80: E501 line too long (80 > 79 characters) Line 128:80: E501 line too long (80 > 79 characters) Line 131:80: E501 line too long (83 > 79 characters) Line 158:80: E501 line too long (98 > 79 characters) Line 471:80: E501 line too long (84 > 79 characters) Line 512:80: E501 line too long (80 > 79 characters) Line 552:80: E501 line too long (89 > 79 characters) Line 553:80: E501 line too long (93 > 79 characters) Line 579:80: E501 line too long (84 > 79 characters) Line 662:80: E501 line too long (85 > 79 characters) Line 678:80: E501 line too long (80 > 79 characters) Line 710:80: E501 line too long (80 > 79 characters) Line 719:80: E501 line too long (91 > 79 characters) Line 793:80: E501 line too long (85 > 79 characters) Line 800:80: E501 line too long (81 > 79 characters) Line 806:80: E501 line too long (90 > 79 characters) Line 816:80: E501 line too long (98 > 79 characters) Line 839:80: E501 line too long (85 > 79 characters) Line 860:80: E501 line too long (96 > 79 characters) Line 907:80: E501 line too long (152 > 79 characters) Line 974:80: E501 line too long (91 > 79 characters) Line 977:80: E501 line too long (107 > 79 characters) Line 983:80: E501 line too long (94 > 79 characters) Line 985:80: E501 line too long (100 > 79 characters) Line 988:80: E501 line too long (87 > 79 characters) Line 990:80: E501 line too long (115 > 79 characters) Line 992:80: E501 line too long (89 > 79 characters) Line 994:80: E501 line too long (89 > 79 characters) Line 997:80: E501 line too long (85 > 79 characters) Line 1016:80: E501 line too long (103 > 79 characters) Line 1040:5: E303 too many blank lines (2) Line 1073:5: E303 too many blank lines (2) Line 1077:80: E501 line too long (88 > 79 characters) Line 1194:80: E501 line too long (83 > 79 characters) Line 1204:80: E501 line too long (94 > 79 characters) Line 1216:80: E501 line too long (83 > 79 characters) Line 1218:80: E501 line too long (91 > 79 characters) Line 1228:16: E126 continuation line over-indented for hanging indent Line 1229:16: E126 continuation line over-indented for hanging indent Line 1231:80: E501 line too long (94 > 79 characters) Line 1243:80: E501 line too long (87 > 79 characters) Line 1267:80: E501 line too long (86 > 79 characters) Line 1276:80: E501 line too long (86 > 79 characters) Line 1280:9: E122 continuation line missing indentation or outdented Line 1280:80: E501 line too long (121 > 79 characters) Line 1281:80: E501 line too long (129 > 79 characters) Line 1294:80: E501 line too long (80 > 79 characters) Line 1295:80: E501 line too long (154 > 79 characters) Line 1333:80: E501 line too long (89 > 79 characters) Line 1359:80: E501 line too long (81 > 79 characters) Line 1443:80: E501 line too long (83 > 79 characters) Line 1508:80: E501 line too long (83 > 79 characters) Line 1532:80: E501 line too long (93 > 79 characters) Line 1665:13: E124 closing bracket does not match visual indentation Line 1666:18: E124 closing bracket does not match visual indentation Line 1667:23: E124 closing bracket does not match visual indentation Line 1668:28: E124 closing bracket does not match visual indentation

• In the file usr/share/system-installer/UI/progress.py:

Line 30:1: E402 module level import not at top of file Line 31:1: E402 module level import not at top of file Line 111:5: E303 too many blank lines (2)

• In the file usr/share/system-installer/UI/report.py:

Line 37:1: E402 module level import not at top of file Line 317:9: E722 do not use bare 'except' Line 354:9: E722 do not use bare 'except' Line 425:80: E501 line too long (98 > 79 characters) Line 427:80: E501 line too long (98 > 79 characters) Line 454:80: E501 line too long (81 > 79 characters) Line 480:80: E501 line too long (80 > 79 characters) Line 483:80: E501 line too long (80 > 79 characters) Line 529:80: E501 line too long (80 > 79 characters) Line 597:80: E501 line too long (80 > 79 characters) Line 678:80: E501 line too long (81 > 79 characters)

• In the file usr/share/system-installer/UI/success.py:

Line 34:1: E402 module level import not at top of file Line 75:80: E501 line too long (90 > 79 characters) Line 295:80: E501 line too long (86 > 79 characters) Line 300:80: E501 line too long (80 > 79 characters) Line 337:80: E501 line too long (83 > 79 characters) Line 379:80: E501 line too long (93 > 79 characters) Line 380:80: E501 line too long (93 > 79 characters) Line 384:80: E501 line too long (94 > 79 characters) Line 388:80: E501 line too long (94 > 79 characters) Line 395:80: E501 line too long (99 > 79 characters) Line 413:80: E501 line too long (81 > 79 characters) Line 427:80: E501 line too long (97 > 79 characters)

• In the file usr/share/system-installer/auto_partitioner.py:

Line 110:22: E225 missing whitespace around operator Line 127:80: E501 line too long (80 > 79 characters) Line 199:80: E501 line too long (87 > 79 characters) Line 202:80: E501 line too long (85 > 79 characters) Line 204:80: E501 line too long (95 > 79 characters) Line 206:80: E501 line too long (85 > 79 characters) Line 209:80: E501 line too long (83 > 79 characters) Line 221:80: E501 line too long (80 > 79 characters) Line 223:80: E501 line too long (87 > 79 characters) Line 260:80: E501 line too long (95 > 79 characters) Line 262:80: E501 line too long (83 > 79 characters) Line 265:80: E501 line too long (81 > 79 characters) Line 267:80: E501 line too long (94 > 79 characters) Line 269:80: E501 line too long (83 > 79 characters) Line 271:80: E501 line too long (81 > 79 characters) Line 284:80: E501 line too long (81 > 79 characters) Line 287:80: E501 line too long (82 > 79 characters) Line 295:80: E501 line too long (85 > 79 characters) Line 303:80: E501 line too long (82 > 79 characters) Line 305:80: E501 line too long (135 > 79 characters) Line 306:80: E501 line too long (81 > 79 characters) Line 307:80: E501 line too long (95 > 79 characters) Line 308:80: E501 line too long (113 > 79 characters) Line 310:80: E501 line too long (93 > 79 characters) Line 312:80: E501 line too long (133 > 79 characters) Line 313:80: E501 line too long (81 > 79 characters) Line 314:80: E501 line too long (95 > 79 characters) Line 315:80: E501 line too long (117 > 79 characters) Line 316:80: E501 line too long (93 > 79 characters) Line 317:80: E501 line too long (141 > 79 characters) Line 320:80: E501 line too long (141 > 79 characters) Line 333:17: E722 do not use bare 'except' Line 338:80: E501 line too long (100 > 79 characters) Line 413:80: E501 line too long (96 > 79 characters) Line 482:80: E501 line too long (86 > 79 characters) Line 493:80: E501 line too long (80 > 79 characters) Line 564:80: E501 line too long (85 > 79 characters) Line 599:80: E501 line too long (92 > 79 characters) Line 600:80: E501 line too long (100 > 79 characters) Line 614:80: E501 line too long (80 > 79 characters)

• In the file usr/share/system-installer/check_kernel_versions.py:

Line 87:80: E501 line too long (92 > 79 characters) Line 88:80: E501 line too long (93 > 79 characters)

• In the file usr/share/system-installer/engine.py:

Line 105:80: E501 line too long (81 > 79 characters) Line 110:80: E501 line too long (82 > 79 characters) Line 112:80: E501 line too long (80 > 79 characters) Line 113:30: E128 continuation line under-indented for visual indent Line 114:80: E501 line too long (95 > 79 characters) Line 121:80: E501 line too long (87 > 79 characters) Line 142:22: E128 continuation line under-indented for visual indent Line 150:22: E128 continuation line under-indented for visual indent Line 152:80: E501 line too long (100 > 79 characters)

• In the file usr/share/system-installer/installer.py:

Line 70:80: E501 line too long (86 > 79 characters) Line 71:80: E501 line too long (82 > 79 characters) Line 122:80: E501 line too long (82 > 79 characters) Line 179:13: E128 continuation line under-indented for visual indent Line 195:80: E501 line too long (82 > 79 characters) Line 196:80: E501 line too long (80 > 79 characters) Line 197:80: E501 line too long (87 > 79 characters) Line 204:80: E501 line too long (84 > 79 characters) Line 205:80: E501 line too long (83 > 79 characters) Line 215:80: E501 line too long (81 > 79 characters) Line 231:80: E501 line too long (90 > 79 characters) Line 236:80: E501 line too long (86 > 79 characters) Line 243:80: E501 line too long (90 > 79 characters) Line 261:80: E501 line too long (96 > 79 characters) Line 281:80: E501 line too long (86 > 79 characters) Line 282:80: E501 line too long (92 > 79 characters) Line 285:59: W504 line break after binary operator

• In the file usr/share/system-installer/modules/auto_login_set.py:

Line 29:1: E302 expected 2 blank lines, found 1 Line 65:1: E305 expected 2 blank lines after class or function definition, found 1

• In the file usr/share/system-installer/modules/install_extras.py:

Line 51:80: E501 line too long (80 > 79 characters) Line 56:80: E501 line too long (93 > 79 characters) Line 59:80: E501 line too long (128 > 79 characters) Line 96:80: E501 line too long (102 > 79 characters) Line 97:80: E501 line too long (86 > 79 characters)

• In the file usr/share/system-installer/modules/make_swap.py:

Line 32:1: E302 expected 2 blank lines, found 1 Line 64:1: E305 expected 2 blank lines after class or function definition, found 1

• In the file usr/share/system-installer/modules/make_user.py:

Line 48:80: E501 line too long (100 > 79 characters) Line 71:80: E501 line too long (80 > 79 characters) Line 77:80: E501 line too long (80 > 79 characters)

• In the file usr/share/system-installer/modules/master.py:

Line 204:80: E501 line too long (83 > 79 characters) Line 207:80: E501 line too long (82 > 79 characters) Line 218:80: E501 line too long (88 > 79 characters) Line 222:80: E501 line too long (85 > 79 characters) Line 344:80: E501 line too long (80 > 79 characters) Line 347:80: E501 line too long (87 > 79 characters) Line 353:80: E501 line too long (81 > 79 characters) Line 418:80: E501 line too long (127 > 79 characters) Line 419:80: E501 line too long (109 > 79 characters) Line 436:80: E501 line too long (131 > 79 characters) Line 437:80: E501 line too long (119 > 79 characters)

• In the file usr/share/system-installer/modules/set_locale.py:

Line 53:80: E501 line too long (82 > 79 characters) Line 72:5: E125 continuation line with same indent as next logical line Line 72:13: E124 closing bracket does not match visual indentation

• In the file usr/share/system-installer/modules/set_time.py:

Line 46:1: E303 too many blank lines (3)

• In the file usr/share/system-installer/modules/verify_install.py:

Line 50:47: W605 invalid escape sequence '\E' Line 50:51: W605 invalid escape sequence '\s' Line 50:59: W605 invalid escape sequence '\s' Line 50:80: E501 line too long (80 > 79 characters) Line 102:80: E501 line too long (87 > 79 characters) Line 127:80: E501 line too long (86 > 79 characters)

• In the file usr/share/system-installer/oem/post_install/UI.py:

Line 34:1: E402 module level import not at top of file Line 36:1: E402 module level import not at top of file Line 97:80: E501 line too long (80 > 79 characters) Line 217:80: E501 line too long (83 > 79 characters) Line 247:80: E501 line too long (83 > 79 characters) Line 299:32: E128 continuation line under-indented for visual indent Line 299:32: W503 line break before binary operator Line 413:5: E303 too many blank lines (2) Line 466:68: E231 missing whitespace after ',' Line 495:41: E127 continuation line over-indented for visual indent

• In the file usr/share/system-installer/oem/post_install/configure/auto_login_set.py:

Line 29:1: E302 expected 2 blank lines, found 1 Line 65:1: E305 expected 2 blank lines after class or function definition, found 1

• In the file usr/share/system-installer/oem/post_install/configure/set_locale.py:

Line 53:80: E501 line too long (82 > 79 characters) Line 72:5: E125 continuation line with same indent as next logical line Line 72:13: E124 closing bracket does not match visual indentation

• In the file usr/share/system-installer/oem/post_install/configure/set_time.py:

Line 46:1: E303 too many blank lines (3)

• In the file usr/share/system-installer/oem/pre_install.py:

Line 33:1: E402 module level import not at top of file Line 67:80: E501 line too long (80 > 79 characters) Line 70:80: E501 line too long (80 > 79 characters) Line 73:80: E501 line too long (83 > 79 characters) Line 93:80: E501 line too long (82 > 79 characters) Line 119:80: E501 line too long (84 > 79 characters) Line 192:80: E501 line too long (85 > 79 characters) Line 208:80: E501 line too long (80 > 79 characters) Line 240:80: E501 line too long (80 > 79 characters) Line 249:80: E501 line too long (91 > 79 characters) Line 323:80: E501 line too long (85 > 79 characters) Line 330:80: E501 line too long (81 > 79 characters) Line 336:80: E501 line too long (90 > 79 characters) Line 346:80: E501 line too long (98 > 79 characters) Line 369:80: E501 line too long (85 > 79 characters) Line 396:80: E501 line too long (90 > 79 characters) Line 414:80: E501 line too long (82 > 79 characters) Line 443:5: E303 too many blank lines (2) Line 540:1: E303 too many blank lines (3)

[Batcastle]

This ALSO fixes issues #50 , #51 , and #52