fix rsync URL, fix BIOS installation failure, add abilitiy to disable reporting circumstantially

[Batcastle]

• update rsync URL for Installation Reporting
• Fix BIOS installation failure (BTRFS doesn't have a feature we needed)
• Add ability to disable reporting (don't report a failed installation if it's a second attempt)
• Block attempting an installation before rebooting
• add easier checking of EFI
• PEP8 Improvements

[pep8speaks]

Hello @Batcastle! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file usr/share/system-installer/UI/error.py:

Line 28:1: E402 module level import not at top of file Line 29:1: E402 module level import not at top of file Line 80:1: W293 blank line contains whitespace Line 81:80: E501 line too long (125 > 79 characters) Line 82:80: E501 line too long (80 > 79 characters)

• In the file usr/share/system-installer/UI/main.py:

Line 38:1: E402 module level import not at top of file Line 64:80: E501 line too long (80 > 79 characters) Line 66:80: E501 line too long (82 > 79 characters) Line 115:80: E501 line too long (80 > 79 characters) Line 125:80: E501 line too long (80 > 79 characters) Line 128:80: E501 line too long (80 > 79 characters) Line 131:80: E501 line too long (83 > 79 characters) Line 158:80: E501 line too long (98 > 79 characters) Line 471:80: E501 line too long (84 > 79 characters) Line 512:80: E501 line too long (80 > 79 characters) Line 552:80: E501 line too long (89 > 79 characters) Line 553:80: E501 line too long (100 > 79 characters) Line 579:80: E501 line too long (84 > 79 characters) Line 662:80: E501 line too long (85 > 79 characters) Line 678:80: E501 line too long (80 > 79 characters) Line 710:80: E501 line too long (80 > 79 characters) Line 719:80: E501 line too long (91 > 79 characters) Line 793:80: E501 line too long (85 > 79 characters) Line 800:80: E501 line too long (81 > 79 characters) Line 806:80: E501 line too long (90 > 79 characters) Line 816:80: E501 line too long (98 > 79 characters) Line 839:80: E501 line too long (85 > 79 characters) Line 860:80: E501 line too long (96 > 79 characters) Line 907:80: E501 line too long (152 > 79 characters) Line 974:80: E501 line too long (91 > 79 characters) Line 977:80: E501 line too long (107 > 79 characters) Line 983:80: E501 line too long (94 > 79 characters) Line 985:80: E501 line too long (100 > 79 characters) Line 988:80: E501 line too long (87 > 79 characters) Line 990:80: E501 line too long (115 > 79 characters) Line 992:43: E711 comparison to None should be 'if cond is not None:' Line 993:80: E501 line too long (82 > 79 characters) Line 997:80: E501 line too long (89 > 79 characters) Line 999:80: E501 line too long (89 > 79 characters) Line 1005:80: E501 line too long (85 > 79 characters) Line 1025:80: E501 line too long (103 > 79 characters) Line 1049:5: E303 too many blank lines (2) Line 1082:5: E303 too many blank lines (2) Line 1086:80: E501 line too long (88 > 79 characters) Line 1203:80: E501 line too long (83 > 79 characters) Line 1213:80: E501 line too long (85 > 79 characters) Line 1227:80: E501 line too long (91 > 79 characters) Line 1237:16: E126 continuation line over-indented for hanging indent Line 1238:16: E126 continuation line over-indented for hanging indent Line 1240:80: E501 line too long (94 > 79 characters) Line 1252:80: E501 line too long (87 > 79 characters) Line 1276:80: E501 line too long (86 > 79 characters) Line 1285:80: E501 line too long (86 > 79 characters) Line 1289:9: E122 continuation line missing indentation or outdented Line 1289:80: E501 line too long (121 > 79 characters) Line 1290:80: E501 line too long (129 > 79 characters) Line 1303:80: E501 line too long (80 > 79 characters) Line 1304:80: E501 line too long (154 > 79 characters) Line 1342:80: E501 line too long (89 > 79 characters) Line 1368:80: E501 line too long (81 > 79 characters) Line 1452:80: E501 line too long (83 > 79 characters) Line 1517:80: E501 line too long (83 > 79 characters) Line 1541:80: E501 line too long (93 > 79 characters) Line 1674:13: E124 closing bracket does not match visual indentation Line 1675:18: E124 closing bracket does not match visual indentation Line 1676:23: E124 closing bracket does not match visual indentation Line 1677:28: E124 closing bracket does not match visual indentation

• In the file usr/share/system-installer/auto_partitioner.py:

Line 56:13: E126 continuation line over-indented for hanging indent Line 61:29: E126 continuation line over-indented for hanging indent Line 66:29: E126 continuation line over-indented for hanging indent Line 71:29: E126 continuation line over-indented for hanging indent Line 72:25: E126 continuation line over-indented for hanging indent Line 78:29: E126 continuation line over-indented for hanging indent Line 83:29: E126 continuation line over-indented for hanging indent Line 84:25: E126 continuation line over-indented for hanging indent Line 88:25: E126 continuation line over-indented for hanging indent Line 90:9: E126 continuation line over-indented for hanging indent Line 103:80: E501 line too long (91 > 79 characters) Line 109:39: E221 multiple spaces before operator Line 110:80: E501 line too long (82 > 79 characters) Line 112:80: E501 line too long (98 > 79 characters) Line 113:80: E501 line too long (90 > 79 characters) Line 114:80: E501 line too long (86 > 79 characters) Line 118:80: E501 line too long (83 > 79 characters) Line 120:80: E501 line too long (99 > 79 characters) Line 121:80: E501 line too long (91 > 79 characters) Line 122:80: E501 line too long (87 > 79 characters) Line 127:1: E303 too many blank lines (4) Line 147:5: E116 unexpected indentation (comment) Line 182:22: E225 missing whitespace around operator Line 199:80: E501 line too long (80 > 79 characters) Line 265:5: E303 too many blank lines (2) Line 272:80: E501 line too long (91 > 79 characters) Line 273:80: E501 line too long (81 > 79 characters) Line 275:80: E501 line too long (89 > 79 characters) Line 277:80: E501 line too long (99 > 79 characters) Line 279:80: E501 line too long (89 > 79 characters) Line 282:80: E501 line too long (87 > 79 characters) Line 294:80: E501 line too long (84 > 79 characters) Line 296:80: E501 line too long (91 > 79 characters) Line 333:80: E501 line too long (95 > 79 characters) Line 335:80: E501 line too long (83 > 79 characters) Line 338:80: E501 line too long (81 > 79 characters) Line 340:80: E501 line too long (94 > 79 characters) Line 342:80: E501 line too long (83 > 79 characters) Line 344:80: E501 line too long (81 > 79 characters) Line 357:80: E501 line too long (81 > 79 characters) Line 360:80: E501 line too long (82 > 79 characters) Line 368:80: E501 line too long (85 > 79 characters) Line 376:80: E501 line too long (82 > 79 characters) Line 378:80: E501 line too long (135 > 79 characters) Line 379:80: E501 line too long (81 > 79 characters) Line 380:80: E501 line too long (95 > 79 characters) Line 381:80: E501 line too long (113 > 79 characters) Line 383:80: E501 line too long (93 > 79 characters) Line 385:80: E501 line too long (133 > 79 characters) Line 386:80: E501 line too long (81 > 79 characters) Line 387:80: E501 line too long (95 > 79 characters) Line 388:80: E501 line too long (117 > 79 characters) Line 389:80: E501 line too long (93 > 79 characters) Line 390:80: E501 line too long (141 > 79 characters) Line 393:80: E501 line too long (141 > 79 characters) Line 406:17: E722 do not use bare 'except' Line 411:80: E501 line too long (100 > 79 characters) Line 486:80: E501 line too long (96 > 79 characters) Line 555:80: E501 line too long (86 > 79 characters) Line 566:80: E501 line too long (80 > 79 characters) Line 637:80: E501 line too long (85 > 79 characters) Line 672:80: E501 line too long (92 > 79 characters) Line 673:80: E501 line too long (100 > 79 characters) Line 687:80: E501 line too long (80 > 79 characters)

• In the file usr/share/system-installer/engine.py:

Line 45:1: E302 expected 2 blank lines, found 1 Line 49:22: E128 continuation line under-indented for visual indent Line 57:22: E128 continuation line under-indented for visual indent Line 59:1: E305 expected 2 blank lines after class or function definition, found 1 Line 132:80: E501 line too long (81 > 79 characters) Line 137:80: E501 line too long (82 > 79 characters) Line 139:80: E501 line too long (80 > 79 characters) Line 140:30: E128 continuation line under-indented for visual indent Line 141:80: E501 line too long (95 > 79 characters) Line 148:80: E501 line too long (87 > 79 characters) Line 170:80: E501 line too long (96 > 79 characters)

• In the file usr/share/system-installer/modules/auto_partitioner.py:

Line 1:3: E226 missing whitespace around arithmetic operator Line 1:23: W292 no newline at end of file

• In the file usr/share/system-installer/modules/master.py:

Line 213:80: E501 line too long (83 > 79 characters) Line 216:80: E501 line too long (82 > 79 characters) Line 227:80: E501 line too long (88 > 79 characters) Line 231:80: E501 line too long (85 > 79 characters) Line 350:80: E501 line too long (80 > 79 characters) Line 353:80: E501 line too long (87 > 79 characters) Line 359:80: E501 line too long (81 > 79 characters) Line 424:80: E501 line too long (127 > 79 characters) Line 425:80: E501 line too long (109 > 79 characters) Line 442:80: E501 line too long (131 > 79 characters) Line 443:80: E501 line too long (119 > 79 characters)

• In the file usr/share/system-installer/modules/verify_install.py:

Line 103:80: E501 line too long (87 > 79 characters)

• In the file usr/share/system-installer/oem/auto_partitioner.py:

Line 1:3: E226 missing whitespace around arithmetic operator Line 1:23: W292 no newline at end of file

• In the file usr/share/system-installer/oem/pre_install.py:

Line 35:1: E402 module level import not at top of file Line 64:80: E501 line too long (80 > 79 characters) Line 67:80: E501 line too long (80 > 79 characters) Line 70:80: E501 line too long (83 > 79 characters) Line 89:80: E501 line too long (89 > 79 characters) Line 90:80: E501 line too long (100 > 79 characters) Line 116:80: E501 line too long (84 > 79 characters) Line 189:80: E501 line too long (85 > 79 characters) Line 205:80: E501 line too long (80 > 79 characters) Line 237:80: E501 line too long (80 > 79 characters) Line 246:80: E501 line too long (91 > 79 characters) Line 320:80: E501 line too long (85 > 79 characters) Line 327:80: E501 line too long (81 > 79 characters) Line 333:80: E501 line too long (90 > 79 characters) Line 343:80: E501 line too long (98 > 79 characters) Line 366:80: E501 line too long (85 > 79 characters) Line 392:80: E501 line too long (91 > 79 characters) Line 395:80: E501 line too long (107 > 79 characters) Line 401:80: E501 line too long (94 > 79 characters) Line 403:80: E501 line too long (100 > 79 characters) Line 406:80: E501 line too long (87 > 79 characters) Line 408:80: E501 line too long (115 > 79 characters) Line 410:43: E711 comparison to None should be 'if cond is not None:' Line 411:80: E501 line too long (82 > 79 characters) Line 415:80: E501 line too long (89 > 79 characters) Line 417:80: E501 line too long (89 > 79 characters) Line 423:80: E501 line too long (85 > 79 characters) Line 443:80: E501 line too long (103 > 79 characters) Line 467:5: E303 too many blank lines (2) Line 564:1: E303 too many blank lines (3)

Comment last updated at 2022-06-23 02:27:52 UTC