Documentation updates, QoL improvements

Batcastle commented 1 year ago

Check internet using DNS resolution instead of ICMP
Add Compatibility Mode to Quick Install Files
Added OEM install warning screen
Keep OEM install windows centered
Minor space savings for *.deb file
Add instructions for testing on other distros

Batcastle commented 1 year ago

Tested.

OEM Warning window works. Normal installation works fine. OEM Install hangs at 84%, likely due to APT cache update. Maybe integrate output for that? Investigate if that happens for Normal install. OEM install failed due to:

installArchives() in external apt lib failing
Held packages (Handle them in future update)
Error finding /tmp/system-installer.log (in chroot?) Installed OS could not boot up post-install. No bootloader.

pep8speaks commented 1 year ago

Hello @Batcastle! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file usr/share/system-installer/UI/main.py:

Line 38:1: E402 module level import not at top of file Line 64:80: E501 line too long (80 > 79 characters) Line 66:80: E501 line too long (82 > 79 characters) Line 116:80: E501 line too long (80 > 79 characters) Line 126:80: E501 line too long (80 > 79 characters) Line 129:80: E501 line too long (80 > 79 characters) Line 132:80: E501 line too long (83 > 79 characters) Line 159:80: E501 line too long (98 > 79 characters) Line 227:80: E501 line too long (80 > 79 characters) Line 513:80: E501 line too long (84 > 79 characters) Line 554:80: E501 line too long (80 > 79 characters) Line 594:80: E501 line too long (89 > 79 characters) Line 595:80: E501 line too long (100 > 79 characters) Line 621:80: E501 line too long (84 > 79 characters) Line 704:80: E501 line too long (85 > 79 characters) Line 720:80: E501 line too long (80 > 79 characters) Line 752:80: E501 line too long (80 > 79 characters) Line 761:80: E501 line too long (91 > 79 characters) Line 835:80: E501 line too long (85 > 79 characters) Line 842:80: E501 line too long (81 > 79 characters) Line 848:80: E501 line too long (90 > 79 characters) Line 858:80: E501 line too long (98 > 79 characters) Line 881:80: E501 line too long (85 > 79 characters) Line 902:80: E501 line too long (82 > 79 characters) Line 949:80: E501 line too long (138 > 79 characters) Line 1016:80: E501 line too long (91 > 79 characters) Line 1019:80: E501 line too long (107 > 79 characters) Line 1025:80: E501 line too long (94 > 79 characters) Line 1027:80: E501 line too long (100 > 79 characters) Line 1030:80: E501 line too long (87 > 79 characters) Line 1032:80: E501 line too long (115 > 79 characters) Line 1034:43: E711 comparison to None should be 'if cond is not None:' Line 1035:80: E501 line too long (82 > 79 characters) Line 1039:80: E501 line too long (89 > 79 characters) Line 1041:80: E501 line too long (89 > 79 characters) Line 1047:80: E501 line too long (85 > 79 characters) Line 1067:80: E501 line too long (103 > 79 characters) Line 1091:5: E303 too many blank lines (2) Line 1124:5: E303 too many blank lines (2) Line 1128:80: E501 line too long (88 > 79 characters) Line 1175:9: E303 too many blank lines (2) Line 1287:80: E501 line too long (80 > 79 characters) Line 1291:80: E501 line too long (81 > 79 characters) Line 1455:80: E501 line too long (81 > 79 characters) Line 1458:80: E501 line too long (81 > 79 characters) Line 1514:80: E501 line too long (83 > 79 characters) Line 1536:80: E501 line too long (91 > 79 characters) Line 1546:16: E126 continuation line over-indented for hanging indent Line 1547:16: E126 continuation line over-indented for hanging indent Line 1549:80: E501 line too long (94 > 79 characters) Line 1561:80: E501 line too long (87 > 79 characters) Line 1585:80: E501 line too long (86 > 79 characters) Line 1594:80: E501 line too long (86 > 79 characters) Line 1595:80: E501 line too long (89 > 79 characters) Line 1597:9: E122 continuation line missing indentation or outdented Line 1597:80: E501 line too long (107 > 79 characters) Line 1598:80: E501 line too long (115 > 79 characters) Line 1610:80: E501 line too long (101 > 79 characters) Line 1611:80: E501 line too long (140 > 79 characters) Line 1649:80: E501 line too long (89 > 79 characters) Line 1675:80: E501 line too long (81 > 79 characters) Line 1688:80: E501 line too long (83 > 79 characters) Line 1707:80: E501 line too long (97 > 79 characters) Line 1767:80: E501 line too long (83 > 79 characters) Line 1832:80: E501 line too long (83 > 79 characters) Line 1856:80: E501 line too long (93 > 79 characters) Line 1991:13: E124 closing bracket does not match visual indentation Line 1992:18: E124 closing bracket does not match visual indentation Line 1993:23: E124 closing bracket does not match visual indentation Line 1994:28: E124 closing bracket does not match visual indentation

In the file usr/share/system-installer/UI/report.py:

Line 37:1: E402 module level import not at top of file Line 317:9: E722 do not use bare 'except' Line 354:9: E722 do not use bare 'except' Line 429:80: E501 line too long (98 > 79 characters) Line 456:80: E501 line too long (81 > 79 characters) Line 472:80: E501 line too long (84 > 79 characters) Line 482:80: E501 line too long (80 > 79 characters) Line 485:80: E501 line too long (80 > 79 characters) Line 531:80: E501 line too long (80 > 79 characters) Line 599:80: E501 line too long (80 > 79 characters) Line 698:80: E501 line too long (81 > 79 characters) Line 700:80: E501 line too long (87 > 79 characters) Line 727:1: W391 blank line at end of file

In the file usr/share/system-installer/check_internet.py:

Line 63:5: E722 do not use bare 'except' Line 72:1: W293 blank line contains whitespace

In the file usr/share/system-installer/engine.py:

Line 45:1: E302 expected 2 blank lines, found 1 Line 49:22: E128 continuation line under-indented for visual indent Line 57:22: E128 continuation line under-indented for visual indent Line 59:1: E305 expected 2 blank lines after class or function definition, found 1 Line 115:80: E501 line too long (91 > 79 characters) Line 133:80: E501 line too long (81 > 79 characters) Line 138:80: E501 line too long (82 > 79 characters) Line 140:80: E501 line too long (80 > 79 characters) Line 141:30: E128 continuation line under-indented for visual indent Line 142:80: E501 line too long (95 > 79 characters) Line 149:80: E501 line too long (87 > 79 characters) Line 155:80: E501 line too long (90 > 79 characters) Line 176:80: E501 line too long (96 > 79 characters)

In the file usr/share/system-installer/modules/common.py:

Line 1:3: E226 missing whitespace around arithmetic operator Line 1:13: W292 no newline at end of file

In the file usr/share/system-installer/modules/install_updates.py:

Line 47:80: E501 line too long (82 > 79 characters)

In the file usr/share/system-installer/modules/master.py:

Line 149:40: E127 continuation line over-indented for visual indent Line 150:40: E127 continuation line over-indented for visual indent Line 151:40: E127 continuation line over-indented for visual indent Line 155:36: E127 continuation line over-indented for visual indent Line 156:36: E127 continuation line over-indented for visual indent Line 157:36: E127 continuation line over-indented for visual indent Line 205:31: E127 continuation line over-indented for visual indent Line 213:80: E501 line too long (83 > 79 characters) Line 216:80: E501 line too long (82 > 79 characters) Line 225:23: E127 continuation line over-indented for visual indent Line 227:80: E501 line too long (88 > 79 characters) Line 231:80: E501 line too long (85 > 79 characters) Line 232:22: E127 continuation line over-indented for visual indent Line 234:33: E127 continuation line over-indented for visual indent Line 235:32: E127 continuation line over-indented for visual indent Line 236:32: E127 continuation line over-indented for visual indent Line 237:32: E127 continuation line over-indented for visual indent Line 284:31: E127 continuation line over-indented for visual indent Line 288:28: E127 continuation line over-indented for visual indent Line 292:35: E127 continuation line over-indented for visual indent Line 298:27: E127 continuation line over-indented for visual indent Line 316:31: E127 continuation line over-indented for visual indent Line 348:31: E114 indentation is not a multiple of four (comment) Line 348:31: E116 unexpected indentation (comment) Line 350:80: E501 line too long (83 > 79 characters) Line 353:80: E501 line too long (87 > 79 characters) Line 359:80: E501 line too long (81 > 79 characters) Line 368:27: E127 continuation line over-indented for visual indent Line 372:31: E127 continuation line over-indented for visual indent Line 374:27: E127 continuation line over-indented for visual indent Line 376:27: E127 continuation line over-indented for visual indent Line 378:27: E127 continuation line over-indented for visual indent Line 380:28: E127 continuation line over-indented for visual indent Line 381:27: E127 continuation line over-indented for visual indent Line 387:27: E127 continuation line over-indented for visual indent Line 400:27: E127 continuation line over-indented for visual indent Line 414:37: E127 continuation line over-indented for visual indent Line 430:80: E501 line too long (127 > 79 characters) Line 431:80: E501 line too long (109 > 79 characters) Line 448:80: E501 line too long (131 > 79 characters) Line 449:80: E501 line too long (119 > 79 characters)

In the file usr/share/system-installer/modules/verify_install.py:

Line 52:28: E127 continuation line over-indented for visual indent Line 53:28: E127 continuation line over-indented for visual indent Line 104:80: E501 line too long (87 > 79 characters) Line 138:80: E501 line too long (118 > 79 characters) Line 143:36: E128 continuation line under-indented for visual indent

In the file usr/share/system-installer/oem/post_install/UI.py:

Line 36:1: E402 module level import not at top of file Line 38:1: E402 module level import not at top of file Line 92:80: E501 line too long (80 > 79 characters) Line 216:80: E501 line too long (83 > 79 characters) Line 248:80: E501 line too long (83 > 79 characters) Line 300:32: E128 continuation line under-indented for visual indent Line 300:32: W503 line break before binary operator Line 416:5: E303 too many blank lines (2) Line 469:68: E231 missing whitespace after ',' Line 498:41: E127 continuation line over-indented for visual indent

In the file usr/share/system-installer/oem/pre_install.py:

Line 36:1: E402 module level import not at top of file Line 65:80: E501 line too long (80 > 79 characters) Line 68:80: E501 line too long (80 > 79 characters) Line 71:80: E501 line too long (83 > 79 characters) Line 92:80: E501 line too long (89 > 79 characters) Line 93:80: E501 line too long (100 > 79 characters) Line 119:80: E501 line too long (84 > 79 characters) Line 194:80: E501 line too long (85 > 79 characters) Line 210:80: E501 line too long (80 > 79 characters) Line 242:80: E501 line too long (80 > 79 characters) Line 251:80: E501 line too long (91 > 79 characters) Line 325:80: E501 line too long (85 > 79 characters) Line 332:80: E501 line too long (81 > 79 characters) Line 338:80: E501 line too long (90 > 79 characters) Line 348:80: E501 line too long (98 > 79 characters) Line 371:80: E501 line too long (85 > 79 characters) Line 397:80: E501 line too long (91 > 79 characters) Line 400:80: E501 line too long (107 > 79 characters) Line 406:80: E501 line too long (94 > 79 characters) Line 408:80: E501 line too long (100 > 79 characters) Line 411:80: E501 line too long (87 > 79 characters) Line 413:80: E501 line too long (115 > 79 characters) Line 415:43: E711 comparison to None should be 'if cond is not None:' Line 416:80: E501 line too long (82 > 79 characters) Line 420:80: E501 line too long (89 > 79 characters) Line 422:80: E501 line too long (89 > 79 characters) Line 428:80: E501 line too long (85 > 79 characters) Line 448:80: E501 line too long (103 > 79 characters) Line 472:5: E303 too many blank lines (2) Line 571:1: E303 too many blank lines (3)

SenlisO commented 1 year ago

branch tested and it installs in a virtual machine as well as previous versions do. Still have problems if install restricted extras and update before installing is selected. I also added python3-dev to the list of packages that must be installed before building the application.

drauger-os-development / edamame

Documentation updates, QoL improvements #99