search

draveness / DKNightVersion

Manage Colors, Integrate Night/Multiple Themes. (Unmaintained)
MIT License
3.55k stars 516 forks source link

Test testManagerUseDefaultThemeVersion is broken #6

Closed nordringrayhide closed 9 years ago

nordringrayhide commented 9 years ago

/DKNightVersion/DKNightVersionTests/DKNightVersionManagerTest.m:33:36: Use of undeclared identifier 'DKNightVersion'

/DKNightVersion/DKNightVersionTests/DKNightVersionManagerTest.m:35:28: No known class method for selector 'setUseDefaultNightColor:'

/DKNightVersion/DKNightVersionTests/DKNightVersionManagerTest.m:36:53: No known class method for selector 'useDefaultNightColor'

xcode 6.3, iOS 8.3

draveness commented 9 years ago

In the latest version for DKNightVersion. I have already remove useDefaultNightColor behavior. Because this may cuz unpredictable behavior to UIKit components.

nordringrayhide commented 9 years ago

Yes, normally you're removed some functions, but you should have fixed tests after that, isn't? Right now your tests are broken, that's what I'm telling you.

draveness commented 9 years ago

Already fix this, just minutes ago and thanks for your reminding. I do not understand what you mean in the beginning :+1: