search

draw-dev / DRAW

DRAW: The Dart Reddit API Wrapper
BSD 3-Clause "New" or "Revised" License
87 stars 24 forks source link

added option to expand only one instance of MoreComments #153

Closed donovanrost closed 3 years ago

donovanrost commented 5 years ago

Added the option in replaceMore() to expand only a single instance of MoreComments.

MoreComments is able to get its children, but when a client calls children() on MoreComments, those new Comments are removed from the CommentForest. So it makes sense that CommentForest it able to add new children to itself.

SupremeDeity commented 3 years ago

I took a look at this since i was on the topic of MoreComments and it seems like doing this would go against praw's definition of the replaceMore() function.

Also won't this make the comment list unordered? I honestly think that any who wants to use this should just create their own list and append to it as needed.

That said, currently the skipped list is useless and should be returned together with the remaining MoreComments like its done in praw.

bkonyi commented 3 years ago

That said, currently the skipped list is useless and should be returned together with the remaining MoreComments like its done in praw.

Yes, that's probably the right thing to do. Not sure why that skipped list wasn't ever really used or returned. Would you mind filing an issue? We probably only have to update the return type of replaceMore() to return the list of skipped MoreComment instances.