search

drawRect / Instagram_Stories

Inspired by Instagram Stories functionality. This source is similar to Instagram Stories, which is having both image and video support.
MIT License
415 stars 76 forks source link

move to next or previous picture tap gesture #34

Closed danishnaeem57 closed 5 years ago

danishnaeem57 commented 6 years ago

Hi, first of all, thanks for this awesome library. Can you please tell us, how to implement "move to next or previous picture on tap gesture" just like instagram and whatsapp?

boominadhaprakash commented 6 years ago

Hi @danishnaeem57 Thanks for submitting the issue. The logic behind that move to next and previous is, have to add tap gesture to scrollView in IGStoryPreviewCell and manage the snapIndex based on the gestures direction. You can try with this logic, Even we also started working on this feature with video functionality. Once we have completed this task from our end, we will intimate you.

Thanks, Boominadha Prakash

danishnaeem57 commented 6 years ago

Hi. Any update about previous picture tap gesture?

Thanks.

ranmyfriend commented 6 years ago

Sorry for being late about this fix. Actually, we have fixed it but facing some side effects on this. We were busy with something else. Give us some time. Once we have fixed it let you know @danishnaeem57

Keep in touch :) Thanks, Ranjith

danishnaeem57 commented 6 years ago

Thanks for your reply @ranmyfriend 👍 Please do that ASAP. I am vigorously waiting for this library updates.

chintanTBI commented 5 years ago

Hello, Any update regarding to the functionality of tap to go previous/next? Thanks.

danishnaeem57 commented 5 years ago

can you please tell us, how much time will it take for you guys to implement this feature? Thanks!

Regards.

boominadhaprakash commented 5 years ago

Hi @danishnaeem57 @chintanTBI

Sorry for the delay. Still we are working on it. Will let you know the status by tomorrow.

danishnaeem57 commented 5 years ago

ok @boominadhaprakash we will be waiting for your response.

Thanks.

boominadhaprakash commented 5 years ago

Hi @danishnaeem57 We are working on it. Hope we will fix the bug by this Friday.

danishnaeem57 commented 5 years ago

Thank you so much Sir. Take your time. I will check on it on Friday.

boominadhaprakash commented 5 years ago

@danishnaeem57 We have fixed left and right tap issues for pictures only. Check and don't hesitate to post your feedback as well as issues.

danishnaeem57 commented 5 years ago

hi @boominadhaprakash , thank you so much that you have updated this and added required features. But still there are some problems with the features, you have added. Such as, if you open first story then tap right again and again till last story as quickly as you can, you can identify the problem e.g lagging, crash, damaged image progress bar at top, sometimes incomplete previous progress bar etc. Same goes to tap left.

Another issue is, let say we have 4 stories and we open 3rd story and tap left right away, it should open up 2nd story. but it doesn't.

danishnaeem57 commented 5 years ago

I have attached a zip containing screen recording which will give you better idea about bugs.

bugs.zip

ranmyfriend commented 5 years ago

Thanks. We found ourself this bug yesterday but until otherwise user do fast taps on the picture then only this bug arises. So we are trying to fix this bug as soon as possible and let you know the update.

danishnaeem57 commented 5 years ago

Awesome. Thank you so much guys! keep it up.

boominadhaprakash commented 5 years ago

Hi @danishnaeem57

Greetings, We have fixed that fast tap issues. Kindly go through the source code and play with that from "master" branch. Spread the word. Thanks for your patience. Let us know if you found any issues.

Regards, Boominadha Prakash