search

drawRect / Instagram_Stories

Inspired by Instagram Stories functionality. This source is similar to Instagram Stories, which is having both image and video support.
MIT License
415 stars 76 forks source link

iPad Rotation #64

Closed pcentieiro closed 5 years ago

pcentieiro commented 5 years ago

Hello!

I'm using the library for an Universal app with stories, and while on the iPhone I have the orientation locked to portrait, on iPad I support all orientations (since I want to support the multitasking iPad features). This means that it's necessary to support the stories both on landscape and portrait (the library already does this fine while loading the view controller, but it lacks proper rotations of the UI elements, if the device rotates).

Is this something that can be looked on?

Thanks!

boominadhaprakash commented 5 years ago

Hi @pcentieiro

Actually, we have created and tested this library only on iPhone not in iPad. We will check your issues. Thanks for raising it. It will help us more if you provide screenshots.

Regards, Boominadha Prakash

boominadhaprakash commented 5 years ago

Hi @pcentieiro

We got the issue and we are working on it. Give us some time. Let you know once we fixed that.

pcentieiro commented 5 years ago

Hi @boominadhaprakash !

Thanks for the help! Much appreciated. I've attached some screenshots with this issue.

Open on portrait: OK! Simulator Screen Shot - iPad Pro (11-inch) - 2019-05-15 at 11 21 28

Open on landscape: OK! Simulator Screen Shot - iPad Pro (11-inch) - 2019-05-15 at 11 20 41

Rotating after opening on portrait on landscape: Simulator Screen Shot - iPad Pro (11-inch) - 2019-05-15 at 11 21 32

:(

boominadhaprakash commented 5 years ago

@pcentieiro

Thanks for sharing the screenshots. Will let you know, once we fixed. Thanks for your patience.

Regards, Boominadha Prakash

boominadhaprakash commented 5 years ago

Hi @pcentieiro

We hope that we have fixed the landscape orientation issues. Please checkout or download code from "issues/64" branch.

Let us know if its work fine or not. Side by side, we will also do the testing.

pcentieiro commented 5 years ago

Thanks man!

Looking into it right now. Need to accomodate to the changes that I already did.

Will come back in the next couple of hours.

pcentieiro commented 5 years ago

Hi @boominadhaprakash

Just finished accommodate my logic into what you did, and whoa... it works so smoothly!!! Fantastic job!!!! 😲

I wish I could show you, but we can't release the app yet :) Once it is on the App Store, I'll show you.

This is by far the best support that I got from a iOS library! 🙌

boominadhaprakash commented 5 years ago

Hi @pcentieiro Glad to hear that it worked fine without any issues 👍 Waiting to see your app in App Store. :)