drawRect / Instagram_Stories

Inspired by Instagram Stories functionality. This source is similar to Instagram Stories, which is having both image and video support.
MIT License
415 stars 76 forks source link

I have many warnings #82

Closed Ruuuuddyyy closed 4 years ago

Ruuuuddyyy commented 4 years ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

Screenshot 2020-01-15 at 16 38 19

How to fix this?

ranmyfriend commented 4 years ago

Hi @Ruuuuddyyy

I appreciate your efforts on creating this issue. Sorry to say this. Currently, we are not supporting below 10.0. And if you look at our ReadMe file we mentioned iOS 10 and Xcode 8 is the base version to have this feature.

Ruuuuddyyy commented 4 years ago

Hi @ranmyfriend , but my project version iOS starts from 11.0 and xcode version 11.3.1

ranmyfriend commented 4 years ago

@Ruuuuddyyy Okay got it. Currently, I have Xcode version 11.3. Let me update the version of 11.3.1 and will check and let you know.

ranmyfriend commented 4 years ago

Hi @Ruuuuddyyy

Just now I have updated the Xcode Version and checked it works nicely from my side.

Here is my combination: Xcode Version 11.3.1 (11C504) iOS 13.3 Simulator

Can you please tell me more details about the bug. So I can help you

Ruuuuddyyy commented 4 years ago

I just drag and drop Source folder into my app and after that I have such a list of errors

ranmyfriend commented 4 years ago

Hi @Ruuuuddyyy Thanks for the suggestion. Just now I have created a sample project and copy-pasted the source folder got the warnings.

Related to warnings we have to support iOS13 and regarding the layout error: You need this Enum which is located in IGStoryPreviewController.swift

public enum layoutType {
    case cubic
    var animator: LayoutAttributesAnimator {
        switch self {
        case .cubic:return CubeAttributesAnimator(perspective: -1/100, totalAngle: .pi/12)
        }
    }
}

Thanks for your support. We will fix the warnings and will let you know. give us some time

ranmyfriend commented 4 years ago

Hi @Ruuuuddyyy I have fixed the warnings related to iOS 13.0 and also LayoutType enum error also you won't get. Because I moved this enum into Source folder. Let me know if you face any issues.