search

drawby / shopify-issues

all issues tracked here for shopify theme project
0 stars 0 forks source link

breadcrumbs: style consistent throughout #56

Open GVFTW opened 8 years ago

GVFTW commented 8 years ago

it's functioning properly on products from bottoms collection:

screen shot 2016-02-25 at 1 03 13 pm

but not others

screen shot 2016-02-25 at 12 55 18 pm
EmilioTelevision commented 8 years ago

trying to find where it's not working? It works everywhere I looked and even in the example you screenshot image

GVFTW commented 8 years ago

click one of the product thumbnails in the "featured products" section on the homepage. needs to work on any collection we may add in the future too.

screen shot 2016-02-29 at 7 42 12 pm
EmilioTelevision commented 8 years ago

noticed the urls are different. the homepage links to the product directly. So its not in the collection, thus why it doesn't say featured. http://alala-6.myshopify.com/products/chelsea-mesh-tee http://alala-6.myshopify.com/collections/featured/products/chelsea-mesh-tee I looked at the code and the conditional is in there to add collection if product is in collection image not sure why the homepage doesnt include them in the collection. probably a theme issue. i'll double back

GVFTW commented 8 years ago

yea man there is def more important stuff to focus on, don't sweat this one so much

On Mon, Feb 29, 2016 at 7:59 PM, EmilioTelevision notifications@github.com wrote:

noticed the urls are different. the homepage links to the product directly. So its not in the collection, thus why it doesn't say featured. http://alala-6.myshopify.com/products/chelsea-mesh-tee http://alala-6.myshopify.com/collections/featured/products/chelsea-mesh-tee I looked at the code and the conditional is in there to add collection if product is in collection [image: image] https://cloud.githubusercontent.com/assets/3394886/13414190/b1beffc8-df1e-11e5-9be9-6d21925aa350.png not sure why the homepage doesnt include them in the collection. probably a theme issue. i'll double back

— Reply to this email directly or view it on GitHub https://github.com/drawby/shopify-issues/issues/56#issuecomment-190474507 .

Gabriel Valverde 516-369-5985

EmilioTelevision commented 8 years ago

can't do much about this feature, that url is built into the theme, that one line of code above powers the url for every product link

GVFTW commented 8 years ago

possible solution - can we hide the breadcrumb completely only in this instance? (products that feed from featured collection section on homepage)

hide if it looks like this, but keep as is on all other products

screen shot 2016-03-04 at 7 08 17 pm
EmilioTelevision commented 8 years ago

I'm hiding every tab but the second one which is the collection. in this case I can't hide otherwise I would hide collections on all other pages

On Fri, Mar 4, 2016, 7:11 PM GVFTW notifications@github.com wrote:

possible solution - can we hide the breadcrumb completely only in this instance? (products that feed from featured collection section on homepage)

hide if it looks like this, but keep as is on all other products [image: screen shot 2016-03-04 at 7 08 17 pm] https://cloud.githubusercontent.com/assets/3649059/13543794/d6893168-e23c-11e5-9181-56123d50ccfb.png

— Reply to this email directly or view it on GitHub https://github.com/drawby/shopify-issues/issues/56#issuecomment-192532365 .