Refactor component structure of modal

drawdb-io / drawdb

Free, simple, and intuitive online database design tool and SQL generator.

https://drawdb.vercel.app

MIT License

12.08k stars 851 forks source link

Refactor component structure of modal #124

Open phamhieu275 opened 1 month ago

phamhieu275 commented 1 month ago

I have restructured the source code of the modal component with the following purposes:

There is a modal manager file to handle the overall management of modals in the system.
When adding a new modal, the logic will be written separately within that modal.
For existing export modals that share a common part to rename file, I have created a base modal for a common part.
I have combined the image and SQL export functionalities into a single modal, allowing the selection of corresponding formats.

Please review. Thank you very much.

vercel[bot] commented 1 month ago

@cmc-pvhieu is attempting to deploy a commit to the dottle's projects Team on Vercel.

A member of the Team first needs to authorize it.

1ilit commented 1 month ago

Thank you! Could you please submit each feature in a separate PR so that they can each be reviewed separately.

And no need for drawdb and pdf modals. The modals are there to allow the user to see what they're exporting. Since I'm not planning to have a pdf viewer there's no need to the modal

phamhieu275 commented 1 month ago

@1ilit

I have just separate and keep only refactored code of modal component. When exporting pdf or drawdb data, we cannot edit the file name. Other export functions can be edited, so I created a pdf and drawdb modal to unify the ability to rename exported files.