search

drawdb-io / drawdb

Free, simple, and intuitive online database diagram editor and SQL generator.
https://drawdb.app
GNU Affero General Public License v3.0
22.74k stars 1.59k forks source link

Moved router to a separate folder for better code readability #214

Closed tejasbenibagde closed 1 month ago

vercel[bot] commented 3 months ago

@tejasbenibagde is attempting to deploy a commit to the dottle's projects Team on Vercel.

A member of the Team first needs to authorize it.

tejasbenibagde commented 3 months ago

ok I'm checking

tejasbenibagde commented 3 months ago

wait I tried to understand how you are manipulating the theme, and realized that you unnecessarily wrote too much code in many places just to switch into the light and dark theme and still it is not working, my question is that, if you are using tailwindcss then why did you not create a single separate hook to handle the dark and light mode state, one file(specifically a button) that helps you switch between dark and light theme, also you did not put the colors in the tailwindconfig for different themes, bro your life would have been thousand times easy if you have used the tailwindcss at it's full extent for this purpose. I would have helped you with this problem but I don't get too much time in a day, sorry bro

1ilit commented 3 months ago

@tejasbenibagde because I'm using a UI library that handles theming differently. I can't really control the theme of popovers with tailwind

tejasbenibagde commented 3 months ago

I'm not questioning your choices or the tools you're using; I just wanted to point out that it might have been easier to manage things like the dark/light toggle if Tailwind CSS had been used from the start for this purpose. It could have simplified the process by handling colors, fonts, themes, and more.

tejasbenibagde commented 3 months ago

That said, good luck with your project—it's a big one, and I’m sure it will turn out great!

1ilit commented 3 months ago

Thanks man! I appreciate the contribution