Fix to comments visualization in tables and fields popovers

drawdb-io / drawdb

Free, simple, and intuitive online database design tool and SQL generator.

https://drawdb.app

MIT License

12.11k stars 856 forks source link

Fix to comments visualization in tables and fields popovers #33

Closed santilapi13 closed 2 months ago

santilapi13 commented 2 months ago

I saw issue #26 and I didn't catch what it was refering to (maybe some about bringing comments from SQL code?), but I found out a few bugs in comments display while you hover the mouse over tables and tables' fields.

If a word in a table comment (in the SidePanel) was too long, it would get out of the popover. I fixed it by adding wordBreak:"break-word" to the Popover's style property.
While hovering a field in any table, it would display all its properties except for its comment, so I added it below "Default" section, adding the word-breaking fix too.

This is not a big deal but it would be my first contribution ever, so I hope it helps.

vercel[bot] commented 2 months ago

@santilapi13 is attempting to deploy a commit to the dottle's projects Team on Vercel.

A member of the Team first needs to authorize it.

1ilit commented 2 months ago

Hello! Thank for the contribution.

I can't reproduce the overflow bug

santilapi13 commented 2 months ago

I've just committed suggested changes, but I don't know how to make the pull request again, nor if I have to do it 😅

The "overflow bug" happened with long but non-existent words, for example "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa".:

Breaking words solves this problem:

As you said, I changed the comment div style instead of the Popover style. I gave it a max width so that it grows to a certain point, but it also keeps small if there are only a few words. Now, the UI doesn't break any more. Finally, I also changed "Not comment" to "No comment". Here you have some pictures.

Field1

Field2

Field3

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
drawdb	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 14, 2024 6:57am