Crash on startup

[GoogleCodeExporter]

Hi,

gfeedline is crashing on startup on my machine.

Here is the traceback:

    Traceback (most recent call last):
      File "/usr/bin/gfeedline", line 50, in <module>
        liststore = FeedListStore()
      File "/usr/lib/python2.7/site-packages/gfeedline/liststore.py", line 39, in __init__
        self.append(entry)
      File "/usr/lib/python2.7/site-packages/gfeedline/liststore.py", line 75, in append
        api_obj.start(interval)
      File "/usr/lib/python2.7/site-packages/gfeedline/plugins/base/output.py", line 113, in start
        self.d = self.api.api(self.got_entry, params=self.params)
      File "/usr/lib/python2.7/site-packages/gfeedline/plugins/facebook/account.py", line 41, in home
        return self._get_defer(url, params, cb)
      File "/usr/lib/python2.7/site-packages/gfeedline/plugins/facebook/account.py", line 77, in _get_defer
        return urlget_with_autoproxy(str(url), cb=cb)
      File "/usr/lib/python2.7/site-packages/gfeedline/utils/urlgetautoproxy.py", line 37, in urlget_with_autoproxy
        client = UrlGetWithAutoProxy(url)
      File "/usr/lib/python2.7/site-packages/gfeedline/utils/urlgetautoproxy.py", line 27, in __init__
        super(UrlGetWithAutoProxy, self).__init__(proxy_url)
      File "/usr/lib/python2.7/site-packages/gfeedline/utils/urlget.py", line 40, in __init__
        self.proxy_host, self.proxy_port = client._parse(proxy)[1:3]
    AttributeError: 'module' object has no attribute '_parse'

I'm using python 2.7.5-1 from ArchLinux.

Original issue reported on code.google.com by franc...@yapok.org on 31 Jul 2013 at 8:29

[GoogleCodeExporter]

This seems to be due to a change in Twisted (13.1 removes client._parse)

It might be worked around by importing the code into gfeedline (you'll need 
_URL and _parse from 
http://twistedmatrix.com/trac/browser/trunk/twisted/web/client.py?rev=38672&form
at=txt )

Original comment by franc...@yapok.org on 31 Jul 2013 at 8:49

[GoogleCodeExporter]

Original comment by yendo0206 on 31 Jul 2013 at 11:49

• Changed state: Accepted

[GoogleCodeExporter]

Fixed in revision 03f702dbfa65.

I released 2.3.2 beta 3.
Could you try it?

Original comment by yendo0206 on 14 Aug 2013 at 1:47

• Changed state: Fixed

[GoogleCodeExporter]

I still have a startup crash problem with 2.3.3:

$ gfeedline 
Traceback (most recent call last):
  File "/usr/bin/gfeedline", line 50, in <module>
    liststore = FeedListStore()
  File "/usr/lib/python2.7/site-packages/gfeedline/liststore.py", line 39, in __init__
    self.append(entry)
  File "/usr/lib/python2.7/site-packages/gfeedline/liststore.py", line 75, in append
    api_obj.start(interval)
  File "/usr/lib/python2.7/site-packages/gfeedline/plugins/base/output.py", line 113, in start
    self.d = self.api.api(self.got_entry, params=self.params)
  File "/usr/lib/python2.7/site-packages/gfeedline/plugins/facebook/account.py", line 41, in home
    return self._get_defer(url, params, cb)
  File "/usr/lib/python2.7/site-packages/gfeedline/plugins/facebook/account.py", line 77, in _get_defer
    return urlget_with_autoproxy(str(url), cb=cb)
  File "/usr/lib/python2.7/site-packages/gfeedline/utils/urlgetautoproxy.py", line 38, in urlget_with_autoproxy
    d = client.getPage(url, **kargs)
  File "/usr/lib/python2.7/site-packages/gfeedline/utils/urlget.py", line 46, in getPage
    d = self._urlget(factory, url, contextFactory)
  File "/usr/lib/python2.7/site-packages/gfeedline/utils/urlget.py", line 57, in _urlget
    if client._parse(url) != self._parse(url):
AttributeError: 'module' object has no attribute '_parse'

If you open urlget.py at line 57 there is a call to client._parse followed by a 
print statement (I guess for debug). Removing it makes gfeedline start correctly

Except from that it's running great, thanks!

Original comment by franc...@yapok.org on 19 Aug 2013 at 6:39

[GoogleCodeExporter]

Thank for your testing and report.
Fixed in revision faf107de610a. 
I released fixed 2.3.2 RC1 version.

Original comment by yendo0206 on 25 Aug 2013 at 8:03

[GoogleCodeExporter]

Le dimanche 25 août 2013 à 08:03 +0000, gfeedline@googlecode.com a
écrit :

I confirm that it's starting correctly now. Thanks!

Original comment by franc...@yapok.org on 27 Aug 2013 at 6:25

[GoogleCodeExporter]

Thanks!

Original comment by yendo0206 on 27 Aug 2013 at 6:30

• Changed state: Verified