drawpile / Drawpile

A collaborative drawing program
http://drawpile.net/
GNU General Public License v3.0
1.04k stars 131 forks source link

Yet another brush dock redesign #437

Closed callaa closed 7 years ago

callaa commented 7 years ago

Since the previous change to the brush dock (replacement of the tool slot buttons with the pie menu) was not received well, I think another redesign is needed.

Mockup:

drawpile-main

This design brings back the brush slot buttons, but also provides a box for stored presets, thus combining the good parts from the old system and the preset pie.

The pen, brush and watercolor are merged into a single freehand tool. Whether the tool draws in hard-edge mode (pen), soft mode (brush) or smudge mode (watercolor) depends on the selected brush. This decouples the brush from the active tool type, allowing you to use all brushes with the shape tools as well. (E.g. use the straight line tool with a watercolor brush.)

Another change is that the eraser would no longer be a separate tool. Instead, any brush could be switched into eraser mode.

The main brush dock offers quick access to the most commonly needed brush settings. Clicking on the settings button (top right) would pop up the full brush configuration view.

drawpile-brushedit

(rough mockup)

Whether the brush operates in pen, soft brush or watercolor mode can be selected here. In the future, more modes and shapes can be added as well.

Improvements over the current UI:

Opinions and suggestions welcome!

leandro2222 commented 7 years ago

"This design brings back the brush slot buttons": Good! I don't need to call another shortcut to switch tools. "The pen, brush and watercolor are merged into a single freehand tool": Good! Less is more; simple is best. "...any brush could be switched into eraser mode": Good! I miss the ability to use the line tool with eraser (currenty I workaround it using linetool+white when I'm on the bottom layer).

NewSpice commented 7 years ago

I love this idea! No complaints at all. From your mock-ups provided it's hard for me to interpret where the eraser will be; However, as long as it's a button on the interface and not a keyboard/stylus shortcut, I'll be happy with it!

blurymind commented 7 years ago

Why not have both designs :) i liked the pie design

On 1 Apr 2017 10:52, "NewSpice" notifications@github.com wrote:

I love this idea! No complaints at all. From your mock-ups provided it's hard for me to interpret where the eraser will be; However, as long as it's a button on the interface and not a keyboard/stylus shortcut, I'll be happy with it!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/drawpile/Drawpile/issues/437#issuecomment-290909730, or mute the thread https://github.com/notifications/unsubscribe-auth/AGMbVbXrBCnyUX-0bgdnmXvkNOJjjvhnks5rrh4egaJpZM4MtNEO .

notfood commented 7 years ago

I like the shortcuts. Ctrl+number to set, number to get. Up to 10 presets. Please keep that feature. I don't really care/mind about the buttons, I'd be happy if I could just hide them.

Pie was new and new requires learning. Just have it as an extra feature that can be toogled on or off.

The rests of the mockup features sound like an improvement.

callaa commented 7 years ago

A test release that includes the new UI is now out: https://drawpile.net/news/release-2.0.3-pre1

notfood commented 7 years ago

I dislike the idea of brush settings in non dockable inner window, it clutters the taskbar unnecessarily.

screenshot_20170408_184329

The brush palette can be its own dock.

My suggestion is to make the brush settings dockable and separate brush palette from brush preview, so we can hide the palette for those who find it useless.

And woe is me, no more than 5 presets now... I'll miss going up to 10. I'll also miss being able to set them with the ctrl + number key combo. That feature in 2.x is good.

callaa commented 7 years ago

Moving the palette to its own dock will free up some empty space in the brush dock, so perhaps it would be best to just show all the sliders in the dock like before. The reason for moving them into a separate window was to better support alternative brushes in the future, but perhaps planning for that was premature.

And woe is me, no more than 5 presets now... I'll miss going up to 10. I'll also miss being able to set them with the ctrl + number key combo. That feature in 2.x is good.

This is one of those situations where it's impossible to please everyone. Quite a few people complained about the lack of the old-style buttons. Although, if I move the eraser+mode buttons onto their own row, there should be room for more than 5 buttons.

notfood commented 7 years ago

Well, I don't mind not having 10 presents.

The feature I really liked was being able to set presets by ctrl + number. But since changes are saved at any modification in the new/old view, that feature wouldn't work.

soljak commented 7 years ago

I like this but unless I'm just not seeing them, I seem to be missing the buttons to change the various pressure settings like opacity, size, and hardness.

EDIT: Ah I've discovered them after all.

callaa commented 7 years ago

I just uploaded new test builds:

Changes:

Opinions on the new version?

notfood commented 7 years ago

I don't understand why we need hard brush and soft brush when the hardness slider at 100% turns the soft one into the hard one. They are pretty much the same.

I like that I can hide the brush dock without losing everything else.

I love the color erase tool.

I love that the pointer is easier to look with the new color contrast.

I like the blend modes position.

Thing I miss from 1.x version: The colored icons for each preset. They were useful to know what was what. In this version if I close today and open it tomorrow, I don't know what is what at first glance.

Overall it's good.

callaa commented 7 years ago

I don't understand why we need hard brush and soft brush when the hardness slider at 100% turns the soft one into the hard one. They are pretty much the same.

Unlike the soft brush even at 100%, the hard edge brush has no antialiasing, which makes it useful for pixel art.

The colored icons for each preset.

How about this: (I also tried changing the color of the buttons themselves, but that didn't look so good.)

colorstrip

notfood commented 7 years ago

Ah. Call it pen instead of brush then, most drawapps do so.

That looks nice and clean.

ShyDoge commented 7 years ago

I absolutely LOVE the fact you can use eraser with any brush now, it makes it much easier and faster to do artwork! I personally only use drawpile for my art and I really like how simple it is to use. One thing that would be cool would be if there could be two hotkeys to slightly rotate the canvas, that like manipulate the slider left and right a bit instead of having 90, 180 and 270 degree angles, but of course just using the slider is okay, it would just be a bit more convenient.

callaa commented 7 years ago

Call it pen instead of brush then, most drawapps do so.

Yes, that's a good idea.

One thing that would be cool would be if there could be two hotkeys to slightly rotate the canvas,

I added hotkeys for rotating the canvas by 5 degree increments. By default, they're shift+, and shift+., which should correspond to the < and > keys on the US keyboard layout.

callaa commented 7 years ago

Since there seems to be no objections, I'm merging the new brush dock branch to master in preparation of the 2.0.3 release. Thank you for your comments and suggestions, everyone!