drawpile / Drawpile

A collaborative drawing program
http://drawpile.net/
GNU General Public License v3.0
1.03k stars 130 forks source link

Missing Zoom Slider and simple Userlist #717

Closed AltySquid closed 5 years ago

AltySquid commented 5 years ago

Please bring back the Zoomslider the exact same way it used to be. chrome_r3sExvQbBS

The same way there is a simple implementation of the chat, there should be a simple version of the online userlist. Here's a screenshot with short explanations on how l use my drawpile. l'm mostly using drawpile on a Wacom Mobile Studio Pro and don't want to rely on an onscreen keyboard to type in the amount of % l want to zoom in. dp setup

leandro2222 commented 5 years ago

I miss the zoom slider too.

erik90mx commented 5 years ago

We have a zoom slider in the Navigator dock image

Btw: I really like the layout that you have there to organize the docks and tools to get the maximum space for the canvas, taking that in consideration and that we have those sliders in the Navigator, it will be an interesting idea to remove/hide this info bar:

image

And regarding the user list, it is very true that is difficult a lot of time smooth scroll with the pen tablet to see the users in a session. What can be a good solution preserving the new avatar feature?

Regards

callaa commented 5 years ago

You mentioned the virtual keyboard, so I assume a physical keyboard is not available and the Ctrl+lower stylus rocker zoom shortcut is not usable.

However, there are still many other ways to zoom, such as a pinch gesture if you have a touch screen, the zoom buttons in the toolbar and the slider in the navigator.

How are you using the user list? I'm trying to get an idea how it could be improved.

leandro2222 commented 5 years ago

Maybe show the profile with avatar and basic info 'on mouse over' could be a good way to save space in the users list?

AltySquid commented 5 years ago

Thanks for the rather quick feedback from you guys. There are a couple of things l'd also like to add: l usually operate my tablet with just one hand, therefore l don't like to use expresskeys or the scrolling wheel, especially 'cause l have other things mapped to those buttons already. l know that there's a slider in the navigation dock. The thing is, you'd have to change some good musclememory whenever you have the navigator on the left side of the screen just to use the scrollbar. Changing the docks from the left border to the right one, so l can add the navigator to the bottom right is a workaround that l'm trying to get used to. This way, l'll have the bar close to it's original spot. The problem here is that l have to get used to the new placements of all the other docks. Musclememory is being a problem here as well. There definitely are workarounds to this, it's just sad to see a tool being removed that did its job nicely, especially if you've gotten so used to it Here's my workaround setup dp workaround

erik90mx commented 5 years ago

These are some cases when the user list is used:

The normal ways to search somebody in the user list when a session is crowded is:

I didn't have issues with the user list's scroll bar size, when I had a 28 inches monitor to display, but right now I'm using a laptop with an average screen size, so the layout seems to be closer, that's why I have to take better advantage of the size of the canvas (every extra pixel counts). This is a reason I'm very interested in test out this: https://github.com/drawpile/Drawpile/issues/707

Regards

leandro2222 commented 5 years ago

Add an extra dock just to get the zoom slider is bad for me I have a standard size laptop screen so I have the natigator dock hidden. Most keyboard shortcuts are handy when you're using a mouse but not when you're using the pen. I can't understand the downgrade of a feature when it's supposedly to be evolving (it was just perfect before).

erik90mx commented 5 years ago

Well I’m a Wacom pen tablet user (not a display user), so I use a keyboard along the tablet and this change doesn’t affect me at all to be honest, I feel very comfortable using the shortcuts in the keyboard, even my tablet has gestures enable to facilitate the task.

Different hardware has different necessities, and I understand the annoying if you are a Display user (you need access to almost all features using the pointer straightforward), but here Mr. Calle Laakkonen developed a solution that doesn’t affect a lot of users (btw I never used that slider at all), which is a normal decision when you are evolving a project like this one (also a lot of trying and error).

I know the main vendor of tablets world wide is Wacom, so I wanted to know how many possible users can have the same necessity, and I got this investor free info in the web page (first to know their main products)

image

And here is a pie chart showing the sales of those products (to get an idea of what kind of user by probability we expect to use the software)

image

So probably this change doesn’t affect a lot of users, but as you mentioned, the software needs to evolve, is there any other creative and simple way to make zoom in the canvas than bring back the slider?

Like an opinion, for me will be great to get rid of that bottom bar (as I mentioned) to have more free space for the canvas section, but that’s my opinion. Let’s try to explore ideas in this issue tracking.

Regards

erik90mx commented 5 years ago

A good idea can be left the zoom in and out task just in the scope of the Zoom tool (and remove some redundancy in the layout), remarking that it is perfect selectable trough the tools menu.

One very good way to solve this issue can be implement a feature in Photoshop called Scrubby Zoom, where the left-click and drag to the right is to zoom in, and drag to the left to zoom out (it even maintains the normal click to just zoom in a step forward)

Here you can found a better explanation of the process: https://www.designeasy.co/2013/11/what-is-doing-scrubby-zoom-in-photoshop.html

And here you can see it working in a video: https://www.youtube.com/watch?v=gVAonIw55Tc

Regards

callaa commented 5 years ago

The new layout (moving the sliders to the navigator) was in response to a user request. But now, given that I've heard nothing but complaints about it, I'm thinking I'll just have to revert that change.

erik90mx commented 5 years ago

The new layout (moving the sliders to the navigator) was in response to a user request. But now, given that I've heard nothing but complaints about it, I'm thinking I'll just have to revert that change.

This is a very common topic in Open Source projects, or even in other kind of projects where more people is involve, the decision taken process is very hard to do, because the split of opinions.

To get some usability facts about a user interface, some projects (a lot of them from private development) focus in numbers or other "tools" to take a decision regarding the UI and some features:

Right now Drawpile has a Facebook page with 434 members, maybe in this kind of issues might be a good idea to hear the community opinion (a quick pull with an open post to read opinions), or even asking directly in one of the several sessions opened in Drawpile.net for a real time feedback.

Just remember that even in a house, if you live with more people, to accommodate the TV or a furniture in a specific spot, will be very difficult to please everyone at the first time (some of them prefer right, others the left, and others doesn’t even want a TV)… so maybe you can end with another issue telling you again “remove the zoom slider”, but it is complete normal (the important thing is to learn how to proceed).

As I mentioned in other issue, I'm a real admirer of your work here Mr.Calla, what you are doing with this proyect is not an easy task, and I can even imagine that it might feel like "having another job" (I had some similar experiences before), let's take it easy and remember that we all love Drawpile, and want it to shine :)

Regards.

beenyuk commented 5 years ago

@callaa I think the sliders on navigator is convenient too, and close to the other morden painting software. It's alway will has some different opinions about the new feature, also people need some time for getting used to it. Snipaste_2019-03-28_19-28-02

And i make two mockups for navigator layout. Snipaste_2019-03-28_19-28-27

For now, maybe the best solution is has it both? (keep having the sliders on navigator, and add the sliders back on bottom.)

sciicee commented 5 years ago

The new layout (moving the sliders to the navigator) was in response to a user request. But now, given that I've heard nothing but complaints about it, I'm thinking I'll just have to revert that change.

Personally, i like the new navigator with the sliders! It's more easy for me zoom in & out, and overview the canvas at the same time by using same dock. Thanks a lot! It seems fine if put the slider back to bottom right corner, but can we still have the sliders on navigator? Because I really like it.

callaa commented 5 years ago

Yes, it's possible to leave the sliders in the navigator, but if I'm putting the zoom slider back in the status bar, I'd rather remove it from the navigator then for two reasons: it's extra code to maintain for a redundant feature, and it takes up vertical space that's always in limited supply. I suppose I could leave just the zoom slider in and take out everything else (similar to the photoshop example.) I'm not sure if the rotation slider is very useful at all.

erik90mx commented 5 years ago

I agree to maintain the sliders in the navigator, and try to avoid redundancy:

image

I really like this mockup, because it arranges the sliders in a horizontal way, leaving us with more visible area of the canvas.

image

Just 2 days ago, a user asked me “how I rotate the canvas”, and I ended up giving the shortcut CONTROL + SPACEBAR and drag with left click. I don’t remember if the Navigator dock is in the default layout when you first install de application, but that user was new and didn’t saw it, but he/she need it for drawing.

Regards

leandro2222 commented 5 years ago

About the rotation slider, my personal opinion, as a non-professional artist:

Its harder to do lines in some angles, so in traditional art some newbies usually rotate the paper to draw them easier... This is a "hack" or even "cheating" to do it the easiest way but... if your art professor see you doing that, hes probably going to fix your paper on the table with a 'scotch tape' forcing you to learn how to draw lines in every angle without to rotate the paper.

With that in mind, even when I know it would be easier to rotate and do a line in a certain angle, I refuse to rotate the canvas so I improve my progress as an artist. My professors are not here but i remember and respect their advice to avoid this 'hack'. So even knowing it would be a quick shortcut for an easier line, I do not use the rotation slider at all.

beenyuk commented 5 years ago

@callaa

I suppose I could leave just the zoom slider in and take out everything else (similar to the photoshop example.) I'm not sure if the rotation slider is very useful at all.

It sounds not bad and executable.

As to me, i don't use rotation slider often, mostly just zoom slider and mirror. Besides the basic zoom tool, i want to add one more tool of mirror. It's a very useful tool for user overview their works while drawing!

Here are two quick mockups. Snipaste_2019-03-29_17-18-25

leandro2222 commented 5 years ago

If you play with the 'zoom tool' time enought you'll realize that it often gets stuck in the 150% when youre right clicking do decrease the zoom and it dont get lower than that no matter how many times you do a right click.

To reproduce this bug, jut put 150% (or 300% or 450% or 600%) zoom and right click on the canvas with the zoom tool.

callaa commented 5 years ago

I've now reverted most of the changes to to the status bar.