drawrowfly / tiktok-scraper

TikTok Scraper. Download video posts, collect user/trend/hashtag/music feed metadata, sign URL and etc.
4.39k stars 799 forks source link

getMusicInfo documentation is outdated #360

Closed tnoetzel closed 3 years ago

tnoetzel commented 3 years ago

Describe the bug The getMusicInfo documentation is outdated. The data object returned is different.

FWIW, it would be extremely helpful if future updates didn't always change the data objects in question; best practice for scraper tools is to add data while keeping any existing fields the same, that way everybody who uses your library as a dependency doesn't have to change their code for every minor update.

If fields below will be empty then issue will be Ignored and Closed

To Reproduce Steps to reproduce the behavior:

drawrowfly commented 3 years ago

Can't disagree!

Everything else should be the same, at least i have tried to keep it the same.

Will update the docs a bit later

tnoetzel commented 3 years ago

Appreciate the response! I will note, however, that the objects returned are pretty different... field names have changed, most of the data is now nested in an accumulator, etc.

drawrowfly commented 3 years ago

You will not what?)

The current output will stay as it is

tnoetzel commented 3 years ago

*note

If it's stable from now forward, that's awesome!

drawrowfly commented 3 years ago

oh)

Yup i will be stable