search

drawshield / Drawshield-Code

PHP code to create SVG shield images from Blazons, as used on drawshield.net
https://drawshield.net
GNU General Public License v3.0
49 stars 17 forks source link

!todo `two charges in saltire` appear too low #591

Closed karlwilcox closed 1 year ago

karlwilcox commented 1 year ago

!todo two charges in saltire appear too low !draw azure, a cross sable two chains shown much larger in saltire argent four moons decrescent in cross or

ericscheid commented 1 year ago

image

karlwilcox commented 1 year ago

Need to update the logic in arrangements.inc lines 770-790. (There is already a comment "there may be more to do here"!)

karlwilcox commented 1 year ago

The logic to determine whether some set of one or more charges should occupy as much of the shield as possible, or be carefully centred on the cross point is complex and there will be situations when it is wrong. As a sort-of fix I've added the charge modifier "centered" (or "at/on cross point") which will force the charge (or arrangement of charges) to be centred where the arms of the cross meet. Hence the above issue can be addressed with:

!draw azure, a cross sable two chains shown much larger in saltire centered argent four moons decrescent in cross or

I'll put this on the DEV system soon