search

drbap / magicuser-theme-for-obsidian

MagicUser theme for Obsidian.md (light and dark themes)
MIT License
29 stars 1 forks source link

Add card theme style #15

Closed zhouxinghong closed 6 months ago

zhouxinghong commented 6 months ago

Allow users to customize the background color, foreground color, and border color of the following areas image image

image

Label with numbers 1 to 6

drbap commented 6 months ago

Please check theme version 16.4.1. You can customize the color of icons of these areas. Thanks for the suggestion but I don't really intend to add the background color and borders to these areas at this moment. Maybe in the future.

You can also select the color of search icon, status bar icon and menus icons.

UI Settings -> Icons and Folders

drbap commented 6 months ago

Area 4 is not delimited this way, more than 1 div... Anyway, I added your suggestion to the list for future updates. Thanks

drbap commented 6 months ago

I didn't understand Area 6. Linked mentions?

For areas 1, 2 and 3 I can try to implement this feature sooner. Stay tuned, when I have more time I will try to work on this.

zhouxinghong commented 6 months ago

I didn't understand Area 6. Linked mentions?

Area 6 is the background color and foreground color in the editor

drbap commented 6 months ago

Ok. You can already set the background color of the editor (UI Settings -> Main Theme Colors - > Primary background color). I will add the foreground color to the list. Thanks

zhouxinghong commented 6 months ago

Allow customization of the background and foreground colors of Number 1 and Number 2 areas image The background color of the number 3 area is displayed incorrectly.

drbap commented 6 months ago

There is no background color using this color in MagicUser BG series (light mode)... is it a custom color you are using, correct? It is not displaying incorrectly. I didn't understand. Could you explain it better? Thanks

The foreground color of area1 you can already select (folder name color).

drbap commented 6 months ago

Zhou. I don't intend to make it like a card layout (text editor and sidebars) if this is what you are trying to say. MagicUser should have its own look in some areas. Also I can't change the background color of area 1 because you can already use Dark sidebar (in light mode). Besides it can be difficult to see the sidebar open folder area feature.

zhouxinghong commented 6 months ago

There is no background color using this color in MagicUser BG series (light mode)... is it a custom color you are using, correct? It is not displaying incorrectly. I didn't understand. Could you explain it better? Thanks

You can try it yourself. Your customized background color is inconsistent with the actual displayed background color.

drbap commented 6 months ago

Well, I tried it many times. Just captured the screen and used a color picker it is the same color I selected.

Also please update Style Settings to version 1.0.8

drbap commented 6 months ago

You can try it yourself. Your customized background color is inconsistent with the actual displayed background color.

Inconsistent with what? Could you explain it better?

stylesettings_export

Could you post your Style Settings options here or a screenshot of the settings. When you click on "Export". Thanks

zhouxinghong commented 6 months ago

{ "magicuser-theme-for-obsidian@@mu-presets-themes": "magicuser-bg-dreams-theme", "magicuser-theme-for-obsidian@@mu-reading-glow-status-off": true, "magicuser-theme-for-obsidian@@mu-table-outer-border-width-value": 2, "magicuser-theme-for-obsidian@@mu-bg-image-overlay": 0, "magicuser-theme-for-obsidian@@mu-tabs-style": "mu-tabs-pill", "magicuser-theme-for-obsidian@@tab-text-color-focused-active-current@@light": "#C701DD", "magicuser-theme-for-obsidian@@mu-laser-active": false, "magicuser-theme-for-obsidian@@mu-laser-type": "mu-laser-type-line", "magicuser-theme-for-obsidian@@mu-neon-mode-glow-value": 0.5, "magicuser-theme-for-obsidian@@mu-transparency-menus-level": 0.8, "magicuser-theme-for-obsidian@@mu-distraction-free-mode": false, "magicuser-theme-for-obsidian@@mu-compact-prompt": false, "magicuser-theme-for-obsidian@@mu-transparent-prompts-menus": false, "magicuser-theme-for-obsidian@@mu-presets-tables": "none", "magicuser-theme-for-obsidian@@mu-background-color-1@@light": "#E1E9EF", "magicuser-theme-for-obsidian@@mu-warm-screen-mode": 0 }

drbap commented 6 months ago

Where is the inconsistency? You are using a blue background color for the light theme (BG Dreams - light mode). "magicuser-theme-for-obsidian@@mu-presets-themes": "magicuser-bg-dreams-theme", "magicuser-theme-for-obsidian@@mu-background-color-1@@light": "#E1E9EF"

test_style_001

Reset it (arrow), it will become a white background (default for BG series - light mode). I didn't see any inconsistency here. Could you explain it? It was blue, because you had a blue background selected as a primary background (background-color-1).

zhouxinghong commented 6 months ago

Are you sure there is nothing wrong with the custom background color here?

drbap commented 6 months ago

Well, I just used the same color #E1E9EF and took a screenshot... same color (#E1E9EF) as the primary background selected.

zhouxinghong commented 6 months ago

Then I need to try more! In addition, can I add a border color to the editor background color?

drbap commented 6 months ago

screenshot_bg_01 Here is the screenshot. Please try with a color picker (same color -> #E1E9EF)

zhouxinghong commented 6 months ago

Then I need to try more! In addition, can I add a border color to the editor background color? I wanted to have a bit of a card effect.

zhouxinghong commented 6 months ago

I hope you can realize all the above requirements if you have enough time. Because different users have different preferences.

drbap commented 6 months ago

screenshot_bg_02

I added a border in red to be easier to identify... It looks strange to me. WHat do you think?

drbap commented 6 months ago

screenshot_bg_03

Similar to card layout... it is in red to be easier to see...

zhouxinghong commented 6 months ago

It would be great if the borders were thinner

zhouxinghong commented 6 months ago

I think card-style themes are very popular now.

zhouxinghong commented 6 months ago

I think card-style themes are very popular now. Because it looks cuter and not so stiff, because people's aesthetic sense is always tired.

drbap commented 6 months ago

But look at the huge red space... even if you use a different color, it is a bit distracting to me.

zhouxinghong commented 6 months ago

You can refer to other card-style themes before deciding on your style.

drbap commented 6 months ago

Anyway, the default theme look will be the one as it is right now. If I implement this I will make it as a choice, not the default.

But this will take more time.

zhouxinghong commented 6 months ago

Anyway, the default theme look will be the one as it is right now. If I implement this I will make it as a choice, not the default.

But this will take more time.

Very cool!👍🎉😜

drbap commented 6 months ago

I will see what I can do about it during the weekend. Stay tuned!

zhouxinghong commented 6 months ago

friend! If you don’t have enough time for this requirement, you don’t need to implement it. Just close it directly. Besides, I think it takes a lot of your time to do it perfectly, which is not worth it! 😜

drbap commented 6 months ago

Quick Preview

Still have some tests to do... let me know what do you think

DARK MODE

magicuser_theme_cards_interface_dark_mode

LIGHT MODE

magicuser_theme_cards_interface_light_mode

drbap commented 6 months ago

Please check theme version 16.5.0.

All the best