search

drbap / magicuser-theme-for-obsidian

MagicUser theme for Obsidian.md (light and dark themes)
MIT License
33 stars 0 forks source link

autohide ribbon with the container... #37

Closed fredjoe7 closed 6 months ago

fredjoe7 commented 6 months ago

demo54632132232

this is from border theme..

Would it be possible to implement similar auto-hide feature in the magicuser theme as well?

Currently, it appears that the autohide ribbon only hides icons and not the actual container.

drbap commented 6 months ago

A similar feature is available when using the distraction-free mode: https://github.com/drbap/magicuser-theme-for-obsidian#distraction-free-mode

fredjoe7 commented 6 months ago

Yes.. i use distraction free mode often.. but when i want the tabs visible i use this autohide .. which leaves the empty container

drbap commented 6 months ago

If you need to see the tabs (distraction-free mode), you can switch to stacked tabs mode. Another solution is to use the Border theme when you need this type of functionality.

Sorry, but I don't plan to implement this in MagicUser (normal mode). The theme is becoming increasingly complex to maintain (thousands of lines of code). If I keep adding some effects and small animations, the theme may face performance issues. There are already many features in MagicUser, some of them you found today (resizable callouts).

The general user, seeing a wide range of functionalities, may prefer another theme that is much simpler and easier to remember the features. It's okay, this is a free theme, but my time is limited.

If it gets harder and harder to maintain, it stops being enjoyable for me. To maintain the theme, I have to check if the user is in normal mode, distraction-free mode, total concentration mode (combining if the user is in live-preview, source or reading modes, using tabs or stacked tabs, and so forth)... do you understand me? In addition, it has those auto hide options... I have to test on desktop and mobile. Each layer of complexity takes more time to maintain the project as a whole. Thanks for the suggestion, but I don't really want to add this extra layer now.

fredjoe7 commented 6 months ago

A similar feature is available when using the distraction-free mode: https://github.com/drbap/magicuser-theme-for-obsidian#distraction-free-mode

yup i understand. and thanks for this... i never used distraction free mode in combo with autohide ribbon still now

and thanks for taking your time to reply