drbap / magicuser-theme-for-obsidian

MagicUser theme for Obsidian.md (light and dark themes)
MIT License
33 stars 0 forks source link

1 issue, highlighting, 1 request, code block outlines #39

Closed indigofairyx closed 6 months ago

indigofairyx commented 6 months ago

this is THE BEST theme, it has the most customization, without writing\know know our own CSS, of any theme ive tried! Thank you!


im using the "magicuser Accent" preset, in dark mode, and overhauling the colors to be warm, yellow, green, rather than blue and cold.

ive 1 issue that the ==highlight background== color wont change or update when i change it in the settings. the text color will change.

image but am getting this... image

if its any help from the issue above heres the details from "style settings", i changed a lot so theres a chance i make have one setting overriding the highlight background?

{
  "magicuser-theme-for-obsidian@@mu-presets-themes": "magicuser-accent-theme",
  "magicuser-theme-for-obsidian@@mu-titlebar-background@@dark": "#232323",
  "magicuser-theme-for-obsidian@@mu-background-color-1@@dark": "#161616",
  "magicuser-theme-for-obsidian@@mu-background-color-2@@dark": "#131313",
  "magicuser-theme-for-obsidian@@nav-item-background-active@@dark": "#007FFFBF",
  "magicuser-theme-for-obsidian@@mu-caret-color@@dark": "#00FF03",
  "magicuser-theme-for-obsidian@@mu-vault-title@@dark": "#AEFF00",
  "magicuser-theme-for-obsidian@@mu-text-title@@dark": "#1D8300",
  "magicuser-theme-for-obsidian@@mu-inline-title-font-size-value": 2,
  "magicuser-theme-for-obsidian@@mu-file-header-border-value": 3,
  "magicuser-theme-for-obsidian@@mu-line-highlight-border": "line-highlight-border-yellow",
  "magicuser-theme-for-obsidian@@tab-text-color-focused-active-current@@dark": "#F1F1F1",
  "magicuser-theme-for-obsidian@@mu-tabs-style": "mu-tabs-pill",
  "magicuser-theme-for-obsidian@@mu-default-mode-border-color@@dark": "#56FF00",
  "magicuser-theme-for-obsidian@@mu-default-mode-border-value": 2,
  "magicuser-theme-for-obsidian@@mu-stacked-mode-border-value": 4,
  "magicuser-theme-for-obsidian@@mu-reading-glow": "reading-glow-orange",
  "magicuser-theme-for-obsidian@@mu-scrollbar-track-bg@@dark": "#0000005E",
  "magicuser-theme-for-obsidian@@mu-scrollbar-thumb-bg@@dark": "#84848414",
  "magicuser-theme-for-obsidian@@mu-scrollbar-thumb-bg-hover@@dark": "#1D430A69",
  "magicuser-theme-for-obsidian@@mu-warm-screen-mode": 0.34,
  "magicuser-theme-for-obsidian@@mu-neon-mode": true,
  "magicuser-theme-for-obsidian@@mu-neon-mode-glow-value": 0.6,
  "magicuser-theme-for-obsidian@@mu-underline-headings": true,
  "magicuser-theme-for-obsidian@@mu-h1@@dark": "#00FFA0",
  "magicuser-theme-for-obsidian@@mu-h2@@dark": "#6DBD87",
  "magicuser-theme-for-obsidian@@mu-h4@@dark": "#477D34",
  "magicuser-theme-for-obsidian@@mu-h5@@dark": "#5F9F43",
  "magicuser-theme-for-obsidian@@mu-h6@@dark": "#4D8236",
  "magicuser-theme-for-obsidian@@mu-neon-h2-color-hex@@dark": "#866D92",
  "magicuser-theme-for-obsidian@@text-normal@@dark": "#8AFFC5",
  "magicuser-theme-for-obsidian@@mu-text-bold@@dark": "#8AFFAA",
  "magicuser-theme-for-obsidian@@mu-text-italic@@dark": "#FFB9B9",
  "magicuser-theme-for-obsidian@@text-highlight-bg@@dark": "#EFEFEF88",
  "magicuser-theme-for-obsidian@@hidden-text-underline-background-color@@dark": "#E900EFDE",
  "magicuser-theme-for-obsidian@@code-background@@dark": "#273126"
}

and 1 request is add and option that will gives the option to add an outline around ..

i really like this separation in these elements

image

image


Thanks! X

drbap commented 6 months ago

Thank you so much for stopping by and the kind words about the MagicUser theme. Much appreciated!

My comments...

  1. Issue: highlighting. Please check it out the image below.

text_menu_01

The highlight option you were trying to use to control the background color of ==highlight== is to control another feature of the theme (underlined background color of text that appears on hover).

  1. Suggestion: Thanks for this nice suggestion. I really liked it. I will implement this option on the next update.

Thanks again for the feedback! Stay tuned. I will update the theme soon (today or tomorrow).

All the best

drbap commented 6 months ago

Please check theme version 19.8.1. The request was implemented (it works -> 3 modes: live preview, source and reading modes). You have to activate the feature using the command palette, shortcut key or the Style Settings (search for outline code or access the Codemenu).

I hope you enjoy and find it useful. Thanks again for the suggestion.

Here is the overview of the update:

magicuser_outline_code

Style Settings:

Code -> Outline code

All the best

drbap commented 6 months ago

Suggested feature was implemented, so I am closing this issue. If you have other suggestions just open another issue. Thanks

indigofairyx commented 6 months ago

this is great! 😄

Thank you! its appreciated!

drbap commented 6 months ago

Thank you! If you have other suggestions, please let me know.

All the best

indigofairyx commented 6 months ago

will do! thanks for quick turn around and all these extra options in your theme. its my one and only now.

indigofairyx commented 6 months ago

hello again...

loving your theme and obsidian. if i didnt mention i been using it less than a month. its so awesome...

im following up here to show you something. ... i cant say that anything is "broken" here, i have thrown so many plugins into this setup that im still learning...

i havent checked the theme settings yet, or any table formatting settings...

just wanted to note that the inline code outline is being overridden when they are inside of tables

image

im a HOTKEY JUNKIE! haha, which why i was looking this extra detail in my theme. have many cheat sheets to update.

ill go look into the style settings and plugins to see if this was something i did. or do you have any thought on it?

thanks x

drbap commented 6 months ago

It looks like the outline inline code is not working on tables. I will have to check it out. If this is the issue (it is the only thing I noticed different on the image), please open another issue so when possible I will try to fix it.

Thanks

drbap commented 6 months ago

I created a new issue, so I can try to fix it when possible. Stay tuned.

Talk to you there. Thanks