drbap / magicuser-theme-for-obsidian

MagicUser theme for Obsidian.md (light and dark themes)
MIT License
33 stars 0 forks source link

Modify the title h1...h6 to be displayed #4

Closed zhouxinghong closed 1 year ago

zhouxinghong commented 1 year ago

Hello! It is recommended that the titles h1...h6 be modified to be displayed when the mouse is hovering, instead of always displaying h1...h6, which looks too ugly. It is recommended to use extra colors to highlight h1...h6 font colors Window10 Latest version of theme

drbap commented 1 year ago

Hi @zhouxinghong. Thanks for the feedback.

Could you explain the extra colors h1-h6 you said? Are you referring to the colors of the h1-h6 labels (reading mode) or the colors of the actual text of the h1-h6 headings?

You can customize the h1-h6 text colors using the theme's available options in the Style Settings plugin.

About the h1-h6 labels when using Reading mode, I honestly like the way it is. But I will test if it works well with the hover effect (displaying h1-h6 labels only when the user hovers over the titles).

zhouxinghong commented 1 year ago

Could you explain the extra colors h1-h6 you said? Are you referring to the colors of the h1-h6 labels (reading mode) or the colors of the actual text of the h1-h6 headings? image Color in reading mode

zhouxinghong commented 1 year ago

I think it's better to provide settings for these styles so that users can selectively enable it, rather than completely destroying the styles of the previous theme.

drbap commented 1 year ago

Ok. Thanks for explaining.

Do you think it would be useful to have different colors for these h1-h6 labels?

I may try to add this feature using the Style Settings plugin. In your point of view, should the default option be labels on hover only?

drbap commented 1 year ago

Please check theme version 7.3.0. I added the features below to the reading mode. Please let me know if it is working well for you.

Reading mode:

zhouxinghong commented 1 year ago

Ok. Thanks for explaining.

Do you think it would be useful to have different colors for these h1-h6 labels?

I may try to add this feature using the Style Settings plugin. In your point of view, should the default option be labels on hover only?

Um! Yes.👍

drbap commented 1 year ago

Let me know if it is working well for you, so I will close the issue. Thanks for the suggestion. I also changed the font to make it easier to read (h1-h6 labels -> reading mode)

zhouxinghong commented 1 year ago

Further improvements:

image

Number 1: Please use a different highlight color than the title on mouseover

Number 2: Don't show this on mouseover

Number 4: The height of the vertical line on the left when hovering the mouse should remain the same as the title and the color of the vertical line should be different from the title color, so that the appearance will be more beautiful.

Number 5: Can users be allowed to change square corners to rounded corners? image

zhouxinghong commented 1 year ago

It needs to be said again that your theme is currently the most beautiful theme in Obsidian. 👍😜

drbap commented 1 year ago

@zhouxinghong. Thanks again for the feedback and the kind words.

Please answer the questions below:

  1. Why the color of the labels h1-h6 should be different than the h1-h6 text color since they are just indicators of the H1-H6 headings?

  2. Do you think these labels should have one color for each heading (h1-h6) or one label color for all headings?

  3. Right reading indicator: Do you think this indicator should be deleted? Some users find it useful to tell the right border of the paragraph. Maybe I will make it optional.

zhouxinghong commented 1 year ago

Please answer the following questions:

Since tags h1-h6 are just indicators of H1-H6 headings, why should the color of tags h1-h6 be different from the color of h1-h6 text? Answer: The label color is different from the title text color to better highlight the current label number, for example, h1, h2 or h3, h4, h6, etc.

Do you think these tags should use one color for each heading (h1-h6) or one tag color for all headings? Answer: One color should be used for each heading (h1-h6)

Read right indicator: Do you think this indicator should be removed? Some users find it useful for displaying the right border of a paragraph. Maybe I can make it optional Answer: Make it optional and hide it by default

drbap commented 1 year ago

Please check theme version 7.4.0.

Suggestion Number 1:

Please use a different highlight color than the title on mouseover

Answer: You can select label colors h1-h6 for light and dark modes (6 independent colors). So you can give a very colorful look to these labels. You can select the ones you like the most, as it is a matter of personal taste.

The default option has been changed to a light purple color (different color than the default title colors). All labels are the same color to avoid distractions and maintain a consistent look within the theme.

Suggestion Number 2:

Don't show this on mouseover

Answer: Implemented. The default option will show the left reading indicator only. The right indicator can be visible using Style Settings option (3 available options: left only, left and right and no indicators).

Suggestion Number 4:

The height of the vertical line on the left when hovering the mouse should remain the same as the title and the color of the vertical line should be different from the title color, so that the appearance will be more beautiful.

Answer: Not implemented. The vertical line will have to stay the same way as it is right now. I tried to make it smaller but the glow effect didn't look the way I like. Sorry, but this line height will remain the same.

Suggestion Number 5:

Can users be allowed to change square corners to rounded corners?

Answer: Implemented. The default option is "Rounded corners" and the user can select "square corners" using the Style Settings plugin. So you have both options on this newest version (theme 7.4.0).

You can find reading mode settings in the UI Basic Settings of the theme.

I hope you enjoy. Let me know if it is working well for you.

All the best

zhouxinghong commented 1 year ago

I'll first take a look at the improved effect, and then give you feedback later. . .

zhouxinghong commented 1 year ago

Hello! Number 4: Where can I modify the color of the vertical line on the left when the mouse is hovering? image

drbap commented 1 year ago

You can select the left and right indicator color using the Style Settings (UI Basic Settings, or just search for "reading").

drbap commented 1 year ago

Do you want to have another hover effect?. This vertical line only appears when you mouse over the content (text or titles). Move the mouse away and the line disappears.

zhouxinghong commented 1 year ago

Do you want to have another hover effect?. This vertical line only appears when you mouse over the content (text or titles). Move the mouse away and the line disappears.

Um! Yes 👍

drbap commented 1 year ago

Sorry, I don't plan to implement this feature. Thanks again for the feedback.

drbap commented 1 year ago

If I have more time I can try to implement this feature for you and others that may find it useful. Honestly, I don't think this feature will make a big difference to the theme (hover -> hover effect). I hope you understand.

If you have other suggestions please let me know. This one I will not add to the list of features to implement at this moment.

All the best

zhouxinghong commented 1 year ago

The above functions have been improved very well! I hope to continue to work hard to make the theme better! 👍

drbap commented 1 year ago

Thanks for your feedback. It is very important to me. I appreciate it.

zhouxinghong commented 1 year ago

image Number 1: Keep improving it: Can the vertical line on the left be improved to rounded corners and support adjusting the thickness of the vertical line.

drbap commented 1 year ago

@zhouxinghong. I like the way you use these images with labels and numbers. It is easier for me to identify the region of the theme you are talking about. Thanks.

I think it is better to open another issue about this, because the title of the current issue was "Modify the title h1...h6 to be displayed". The feature was already implemented (display on hover and h1-h6 label colors).

This should be another topic/suggestion/issue.

There are some things to consider before implementing this. Anyway, I will see what I can do about it.

drbap commented 1 year ago

I created another issue so we can talk about the vertical line there. Closing this issue. See you there.