drbap / magicuser-theme-for-obsidian

MagicUser theme for Obsidian.md (light and dark themes)
MIT License
33 stars 0 forks source link

Outline inline code inside tables #43

Closed drbap closed 6 months ago

drbap commented 6 months ago

I am opening this issue to fix the inline code outline -> inside tables (thanks to @indigofairyx for noticing it).

Post:

hello again...

loving your theme and obsidian. if i didnt mention i been using it less than a month. its so awesome...

im following up here to show you something. ... i cant say that anything is "broken" here, i have thrown so many plugins into this setup that im still learning...

i havent checked the theme settings yet, or any table formatting settings...

just wanted to note that the inline code outline is being overridden when they are inside of tables

image

im a HOTKEY JUNKIE! haha, which why i was looking this extra detail in my theme. have many cheat sheets to update.

ill go look into the style settings and plugins to see if this was something i did. or do you have any thought on it?

thanks x

Originally posted by @indigofairyx in https://github.com/drbap/magicuser-theme-for-obsidian/issues/39#issuecomment-2133756101

drbap commented 6 months ago

Could you post the source mode code of this table with shortcuts (table of the image), so I don't have to generate a code to test the feature. Thank you.

Like this:

Paste the table code here
indigofairyx commented 6 months ago

sure thing

there in the code from the screen shot. to illustrate my point i copied the the table and then had to break the code in the lower section.

| Action                                                 | Shortcut                 |
| ------------------------------------------------------ | ------------------------ |
| Simplify selection                                     | `Escape`                 |
| Select all                                             | `Ctrl+A`                 |
| Extend selection one character                         | `Shift+Left/right arrow` |
| Extend selection to the beginning of the previous word | `Ctrl+Shift+Left arrow`  |
| Extend selection to the end of the next word           | `Ctrl+Shift+Right arrow` |
| Extend selection to the beginning of the current line  | `Shift+Home`             |
| Extend selection to the end of the current line        | `Shift+End`              |
| Extend selection to the beginning of the note          | `Ctrl+Shift+Home`        |
| Extend selection to the end of the note                | `Ctrl+Shift+End`         |
| Extend selection one page up                           | `Shift`+`Page up`        |
| Extend selection one page down                         | `Shift`+`Page down`      |
|                                                        |                          |
|                                                        |                          |

---

 Copy                     | `Ctrl`+`C`                    
 Cut                      | `Ctrl`+`X`                         
Paste                    | `Ctrl`+`V`                         
Paste without formatting | `Ctrl`+`Shift`+`V`      
Undo                     | `Ctrl`+`Z`                        
Redo                     | `Ctrl`+`Shift`+`Z` or `Ctrl`+`Y`  
Copy paragraph           | `Ctrl`+`C` (with no selected text)
Cut paragraph            | `Ctrl`+`X` (with no selected text) 
drbap commented 6 months ago

Ok thank you very much. It will be faster to fix. Stay tuned.

drbap commented 6 months ago

Ok it was fixed. It will be available on the next update.

drbap commented 6 months ago

test_outline_code_inside_tables

drbap commented 6 months ago

Thanks again for sending the table code, so it was way easier to fix.

indigofairyx commented 6 months ago

youre welcome and thank you!

i wasnt even sure if was the them or one of the table plugins installed.

drbap commented 6 months ago

Please check theme version 20.2.0. I hope it is working well.

If it is working well, you can close this issue.

All the best

indigofairyx commented 6 months ago

these are matching matching the settings again. thank you for the quick fix

indigofairyx commented 6 months ago

i cant close this issuse. i think because you reopened you have to close it on your side

drbap commented 6 months ago

Ok, if you have other suggestions, just let me know. Thanks