drbenvincent / delay-discounting-analysis

Hierarchical Bayesian estimation and hypothesis testing for delay discounting tasks
http://www.inferencelab.com/delay-discounting-analysis/
MIT License
23 stars 9 forks source link

NonParametric and Parametric should have same public methods #172

Closed drbenvincent closed 7 years ago

drbenvincent commented 7 years ago

In one data analysis project, I want to do an analysis on different models, one Parametric and the other NonParametric. But there are issues caused by the fact that we've got additional public methods in the NonParametric class, which aren't in the Parametric class. So this needs to be refactored, so that they both have the same public methods.

Being more rigorous about a specific public interface for all concrete subclasses of Model will aid in doing eventual model comparisons (e.g. #80).

In the Model class

In the NonParametric class

In the Parametric class