search

drbrain / net-http-persistent

Thread-safe persistent connections with Net::HTTP
http://seattlerb.rubyforge.org/net-http-persistent
339 stars 117 forks source link

remove retry logic #100

Closed grosser closed 4 years ago

grosser commented 5 years ago

fixes https://github.com/drbrain/net-http-persistent/issues/37 fixes https://github.com/drbrain/net-http-persistent/issues/89

@tenderlove @timanovsky @drbrain

not sure if this breaks RFC 2616 but idk what part of the readme it was referring to when it mentioned the RFC, I'd assume the closing the connection which is still there

grosser commented 5 years ago

@drbrain does this look good ? ... if ye I'll start fixing the tests

grosser commented 5 years ago

@drbrain looks like the right direction ?

grosser commented 5 years ago

@drbrain looks like the right direction ? (I still need to change all the tests if yes)

grosser commented 5 years ago

added tests

@tenderlove are you able to merge since @drbrain seems to ignore this PR ? :(

grosser commented 5 years ago

releasing this as net-http-persistent-retry so I can use it in my other projects and can declare an actual dependency, will yank if this ever gets merged 🤷‍♂

drbrain commented 4 years ago

Merged, see log above.

grosser commented 4 years ago

awesome, thx! :D