search

drbrain / net-http-persistent

Thread-safe persistent connections with Net::HTTP
http://seattlerb.rubyforge.org/net-http-persistent
339 stars 117 forks source link

Fixes a bug in shutdown, unsure of exact minimal replication case #24

Closed raggi closed 12 years ago

raggi commented 12 years ago

See https://github.com/raggi/net-http-batch/blob/4872c9ad245436e73be56d9789a5c525bbf53b19/lib/net/http/batch.rb#L34

Thanks!

softwaregravy commented 12 years ago

We're seeing this too. I'd love to get this in.

jfirebaugh commented 12 years ago

This occurs when shutdown is called without any connections having been made. So, minimal replication case:

Net::HTTP::Persistent.new.shutdown # NoMethodError: undefined method `delete' for nil:NilClass