drbrain / net-http-persistent

Thread-safe persistent connections with Net::HTTP
http://seattlerb.rubyforge.org/net-http-persistent
339 stars 117 forks source link

limiting bindings of default_proc #64

Closed dominicm closed 5 years ago

dominicm commented 9 years ago

Otherwise the hash’s default_proc will keep references to locals in method connection_for as well as the current instantiation of Net::HTTP:Persistent

dominicm commented 9 years ago

@drbrain Have you had a chance to review this PR? If there is interest in this code change, I can resolve the conflicts and resubmit it.

drbrain commented 5 years ago

This patch is obsolete in net-http-persistent 3 but the problem existed in one place so I ported it.