Sets a default pool size for Windows as Process::RLIMIT_NOFILE is not supported

drbrain / net-http-persistent

Thread-safe persistent connections with Net::HTTP

http://seattlerb.rubyforge.org/net-http-persistent

339 stars 117 forks source link

Sets a default pool size for Windows as Process::RLIMIT_NOFILE is not supported #90

Closed jakauppila closed 5 years ago

jakauppila commented 7 years ago

Sets a default pool size for Windows as Process::RLIMIT_NOFILE is not supported on the OS.

Fixes #79

dsisnero commented 6 years ago

+1 can we get this merged. I am on windows and I am getting this bug

dsisnero commented 6 years ago

+1 can we get this merged?

rebeccab411 commented 6 years ago

Please merge this!

djansen271 commented 6 years ago

+1 Please merge

dsisnero commented 5 years ago

Can we get this merged?

rgzn commented 5 years ago

Has this still not been merged?

ShaneBurkhart commented 5 years ago

It's not clear if this has been merged. Can you merge this if it isn't please? It would be a huge help!

deivid-rodriguez commented 5 years ago

This is straightforward and allows this gem to be used under Windows. Can we merge it?

Guent4 commented 5 years ago

@drbrain, I saw that you have merged couple PRs in recently and I'm not sure who else has merge privileges... Was wondering if this can be merged in; this currently breaks functionality on Windows. Thanks!

rhockenbury commented 5 years ago

@drbrain Along with this merge, are you going to cut a new release soon?