search

drcheap / WindowSizer

WebExtension to quickly resize the window to one of your favorite sizes
https://addons.mozilla.org/en-US/firefox/addon/windowsizer
11 stars 2 forks source link

Change default shortcuts on FF versions before 66 #17

Closed drcheap closed 1 year ago

drcheap commented 3 years ago

Mardus, a reviewer wrote:

The extension shortucts interfere with Windows special character alt codes, such as when I want to type Alt+0149 for a bullet, the window resizes to one of the user-defined sizes as soon as I press 1 after 0 when holding the Alt key down.

I cannot change this in Firefox versions earlier than Firefox 66, as these older versions do not have an extensions shortcut manager.

I recommend making Shift+Alt+[number] the default instead of Alt+[number] in future versions of WindowSizer.

drcheap commented 3 years ago

I did a quick test of what happens to existing configurations when the defaults change, and it does alter existing user shortcuts that were not explicitly changed from the defaults (i.e. it knows if they were never set versus being set to something else and then set back!). For this reason, I am hesitant to make a blanket change to the actual defaults for all current users as that will likely cause havoc for thousands -- all for the benefit of literally a few people that are inexplicably stuck on such old versions of Firefox.

Perhaps I could do a dynamic shortcut change via commands.update(), and only when the browser version is detected as less than 66. However, I'm pretty sure that particular API is not available in the older versions of FF for the same reason that keyboard shortcuts cannot be modified there. I will have to do some more research and see if that is the case.

drcheap commented 1 year ago

Given that FF66 came out over 4 years ago, and there is close to zero WindowSizer users still on a pre-66 version, this is not something that is going to be addressed.