drcika / apc-extension

https://marketplace.visualstudio.com/items?itemName=drcika.apc-extension
MIT License
658 stars 25 forks source link

Not working with the latest VS Code #230

Open Lady-kimi opened 2 weeks ago

Lady-kimi commented 2 weeks ago

free codeee vers

abdarker commented 1 week ago

So what's the problem of just injecting everything into workbench.esm.html?

The problem is that you should learn yourself and delete Apc, as I was told above. So there's no problem at all.

exactly+ find an alternative

XiaMi-Long commented 1 week ago

So what's the problem of just injecting everything into workbench.esm.html那么,将所有内容注入到“workbench.esm.html”中会有什么问题呢??

The problem is that you should learn yourself and delete Apc, as I was told above. So there's no problem at all.问题是你应该自己学习并删除 Apc,正如我上面所说的那样。所以完全没有问题。

exactly+ find an alternative完全+找到替代方案 This approach is fine, you just need to back up the original file. If any issues occur, you can simply restore the backup file. The plugin I developed does the same thing: https://marketplace.visualstudio.com/items?itemName=wwy.easy-anim-code

XiaMi-Long commented 1 week ago

It only works to revert to the previous version of VSCode. 1.93它仅适用于恢复到 VSCode 的先前版本。 1.93

This kind of issue is very rare.The issue this time is likely related to VSCode version 1.94 completing the ESM migration, which led to the files used by the plugins being deleted or renamed, causing the plugins to no longer work properly.

tadghh commented 1 week ago

So what's the problem of just injecting everything into workbench.esm.html?

The problem is that you should learn yourself and delete Apc, as I was told above. So there's no problem at all.

post repo example for lowbies like me? <3

Ender-Wang commented 1 week ago

So what's the problem of just injecting everything into workbench.esm.html?

The problem is that you should learn yourself and delete Apc, as I was told above. So there's no problem at all.

post repo example for lowbies like me? <3

I am also working on it and I cannot make it work, so here I am for help, but the other dude told me to learn it and do it my self, what can I say? 🤷 And that dude does not wanna share his precious CSS or js code.

HyunggyuJang commented 1 week ago

@drcika from playing around locally on a macOS machine, it seems like monkey-patching (manually editing by hand for now) the scripts in Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js still works.

@peterldowns can you elaborate more on what you have changed to make frameless title bar?

drcika commented 1 week ago

find the function that calls the electron create window and modify the config object that is passed createBrowserWindow new BrowserWindow() and modify config https://www.electronjs.org/docs/latest/api/browser-window#new-browserwindowoptions

HyunggyuJang commented 1 week ago

I see, but, haven’t you chosen a different path from that in this repo? I believe you chose to apply a custom css, where frameless css class is defined. Is there any reasons behind that decision?

hologerry commented 6 days ago

Hi @HyunggyuJang and others who might be interested in frameless window. I figured out a monkey patch solution: https://github.com/be5invis/vscode-custom-css/issues/236

simla33 commented 5 days ago

Hi @HyunggyuJang and others who might be interested in frameless window. I figured out a monkey patch solution: be5invis/vscode-custom-css#236

Can confirm that it is working!

If someone also likes to have his activity bar at the top/bottom, you may want to switch "window.titleBarStyle" to "native", otherwise title bar will show up with settings and account tabs.

image

hologerry commented 5 days ago

@simla33 Do you put the frameless into your custom-vscode.css? If so, can you share the content? The solution in https://github.com/be5invis/vscode-custom-css/issues/236 requires manually modify the main.js each time when update releases.

andynameistaken commented 4 days ago

Please make Patreon or something if you feel like spending some time with rewriting extension and getting money compensation for it.

Ender-Wang commented 4 days ago

I would love to pay for this extension to support the dev, worth it imo. It would be nice if it's a one-time payment, not a subscription-based tho.

andynameistaken commented 4 days ago

I would love to pay for this extension to support the dev, worth it imo. It would be nice if it's a one-time payment, not a subscription-based tho.

Option for both would be great.

It is so important for me that I can go without update for months - when Microsoft broke Customize UI I didn't update VSCode for ~7 months or so. @drcika please let us know if we can compensate you any amount of money for rewriting this plugin.

subframe7536 commented 3 days ago

Previous apc user. Feel upset to see this extension no longer works. So I just make a new extension with a subset of features: https://github.com/subframe7536/vscode-custom-ui-style

Kycenko commented 3 hours ago

I'll stay in 1.91.1... I'm happy with it glazewm2

What Linux distribution you're using?

darianmorat commented 2 hours ago

@Kycenko the best one... Windows 11 😅 With glazewm and zebar - it's work in progress for win users