drcmda / mauerwerk

⚒ A react-spring driven masonry-like grid with enter/exit and shared element transitions
MIT License
836 stars 55 forks source link

A problem with the z-index in the demo #2

Closed Ahmed-Ayman closed 6 years ago

Ahmed-Ayman commented 6 years ago

In the simplfied demo the text is appearing under the overlay while testing it on the mobile. Maybe we need to increase the z-index to handle it on the mobile

drcmda commented 6 years ago

Hi @Ahmed-Ayman

oh that's a bummer. I do set z-index on the opening cells (or else other cells would cut into it), but perhaps it needs some deeper consideration. Which device are you using btw?

drcmda commented 6 years ago

Tried it on my iphone now, actually it looks alright to me, i mean - it looks horrible because the circle thing overlays the text beneath - but that's because i haven't made the demo responsive, there are no media queries, etc. Is it this problem you're seeing?

Ahmed-Ayman commented 6 years ago

Yep thats exactly what I was talking about and was thinking like we can handle it by setting a media query and a z-index for it on the mobile! And I'm using xiaomi redmi note 5 A.. Android 8

drcmda commented 6 years ago

The inner content is up to you, the demo just slaps a bunch of absolute divs onto it, i sized it more or less after codesandbox on desktop. I think we're fine :-)

Ahmed-Ayman commented 6 years ago

alright : ) I was just thinking like it it's gonna look more perfect this way, pardon my perfectionism! :'D