search

drcode / webfui

Client-Side Web Framework for ClojureScript
236 stars 19 forks source link

Cljs repl #5

Open dturczanski opened 11 years ago

dturczanski commented 11 years ago

Hi, I don't think it's possible to live code in the browser atm.

If I place a call: (repl/connect "http://localhost:9000/repl")

an iframe is created but it is overwritten by WebFUI since it takes control of the whole body.

It would be great to use cljs repl. Is there a way to run it currently, or any possible workaround?

Thanks, Daniel

drcode commented 11 years ago

Thanks Daniel, I was not aware of the cljs repl feature and therefore am not surprised it doesn't work.

I suppose the library will need to have a check for cljs repl and play nice with it if it's in use. I will leave this issue open and will get to it when I can, but things are hectic in my life right now and it will probably be a while before I can get around to it.

dturczanski commented 11 years ago

Hi Conrad, I took a look at this issue and ended up with these changes: https://github.com/dturczanski/webfui/commit/ce36b0bf71610bef763702f4248fae49a7fde58f

Thanks to this commit, the whole app DOM is put in the div (which's id property is hardcoded to "content") - not straight into the body.

I only tested the change using the basic calculator example and it works great. It is even possible to update the state atom from the REPL and see instant change in the web browser :)

Hope you find time to tell me what you think, are interested in pull requests?