search

drdk / grunt-dr-svg-sprites

Grunt plugin to create SVG sprites with PNG fallbacks at needed sizes
113 stars 19 forks source link

Updated svg2png #51

Open esr360 opened 7 years ago

esr360 commented 7 years ago

Hi, I see the regular non grunt version of this plugin has recently had svg2png updated, presumably to fix issues with phantomJS on latest OSX.

Do you have plans to update the grunt version of this plugin as well? We are currently in a difficult position trying to use grunt-dr-svg-sprites on Mac OSX Sierra with an outdated svg2png using an old version of PhantomJS not supported by this OSX version.

Thanks

phloe commented 7 years ago

We might just be updating all the dependencies - and maybe rewriting a bit (using ES6). We hadn't actually come across any issues - but if it fixes issues that would be a plus :)

I'll update grunt-dr-svg-sprites as soon as dr-svg-sprites is ready.

ci-ryan-garcia commented 7 years ago

Hello, seems I have a similar issue. In updating my dev tools, I noticed an older version wasn't working so I tried to download the latest grunt-dr-svg-sprites Except I can't install the plugin at all. I get the following error in Terminal:

14465 error argv "/usr/local/Cellar/node/7.0.0/bin/node" "/Users/…/.npm-packages/bin/npm" "install" "grunt-dr-svg-sprites" "--save-dev"
14466 error node v7.0.0
14467 error npm  v3.10.9
14468 error code ELIFECYCLE
14469 error phantomjs@1.9.17 install: `node install.js`
14469 error Exit status 1
14470 error Failed at the phantomjs@1.9.17 install script 'node install.js'.
14470 error Make sure you have the latest version of node.js and npm installed.
14470 error If you do, this is most likely a problem with the phantomjs package,
14470 error not with npm itself.
14470 error Tell the author that this fails on your system:
14470 error     node install.js
14470 error You can get information on how to open an issue for this project with:
14470 error     npm bugs phantomjs
14470 error Or if that isn't available, you can get their info via:
14470 error     npm owner ls phantomjs
14470 error There is likely additional logging output above.
14471 verbose exit [ 1, true ]

Using the latest versions of Homebrew, Nodejs and NPM. We have been using the task for our system wide icons for a while.

Thank you for the good work

ci-ryan-garcia commented 7 years ago

I was able to make it work by installing an older version, namely 0.5.5. It seems v0.9.+ gave me the issues.

phloe commented 7 years ago

I just published version 1.0.0 with all dependencies updated - let me know if it fixes you issues :)

ci-ryan-garcia commented 7 years ago

Thank you! I was able to install v1.0.0 without issues. I did have to revert back to v0.5.5 temporarily because it seems the new version formats sprites with added padding on the bottom which seems to change the offset of the icons. It also changed file naming of fallback PNGs. But, that is something I can work with I just need to spend some time with it :)