Open gforsyth opened 7 years ago
Hi! I'm the @bryanwweber that's using Doctr for my two repositories (and I'm setting up a third right now). What do I need to do here?
Nothing until we do a release, but we are deprecating the --gh-pages-docs
flag of doctr deploy
, and replacing it with a requirement argument (like doctr deploy .
). Once we do a release we want to make sure all these repos are updated so that the change will have minimal impact once we remove the flag entirely.
OK got it. I'll watch for the release and update accordingly. Thanks!
Hey @bryanwweber -- the latest doctr has been released, so you should change your doctr deploy
lines to just treat the deploy directory as a required argument.
I'm happy to PR that in if you'd like.
Fixing SymPy at https://github.com/sympy/sympy/pull/12339
Don't. Critical bug
Something in the checks to only push from the master branch isn't working
The push
travis run will push the docs
OK, will hold off.
Something in the checks to only push from the master branch isn't working
That might be in interference with the thing I did with branch whitelists. I'll dig into it as well.
I think I found it -- this line (https://github.com/drdoctr/doctr/blob/master/doctr/travis.py#L166)
if any([re.compile(x).match(TRAVIS_BRANCH) for x in branch_whitelist]):
should be
if not any([re.compile(x).match(TRAVIS_BRANCH) for x in branch_whitelist]):
since we set canpush=False
inside of that conditional. So instead we're allowing pushes from any branch except for master
or anything in the whitelist
Agreed, should we change if branch_whitelist is None
to if not branch_whitelist
, that won't behave the same if branch_whitelist
is set to empty set or empty list.
ooh, yeah. good point. I'll put that in, too.
Ok. 1.5.1 is out and on conda-forge. I've reopened the PRs I had to the repos listed above.
@gforsyth Noted and I will update in the next commit I push to those repos
As of 1.5.0, the
--gh-pages-docs
flag is deprecated in favor of a required command line argument (doctr deploy deploy_dir
). Several repos need to be updated.Following the merge and release of #157
The list of repos I have using doctr (searching for
doctr
and filtering for YAML files) is:[x] https://github.com/pydata/pandas-design (although it says deprecated in the repo description)doctr
just installing it[ ] https://github.com/gallantlab/pycortex/pull/205 (not yet merged) (pinged)https://github.com/Alsheh/tmpsympy forkhttps://github.com/antepsis/anteplahmacunsympy fork