drdoctr / doctr

A tool for automatically deploying docs from Travis CI to GitHub pages.
https://drdoctr.github.io
MIT License
107 stars 30 forks source link

Don't run doctr on a commit generated by doctr #316

Closed asmeurer closed 6 years ago

asmeurer commented 6 years ago

See https://github.com/drdoctr/doctr/issues/314. If you accidentally run Travis on the GitHub pages branch, then doctr will run into an infinite loop, triggering a build each time it pushes a commit. This is generally a misconfiguration, but we should avoid running doctr when this happens. Maybe it should be an error by default to alert the user that they messed up. We can check that the commit email is the one that doctr sets (doctr@noreply.github.com or something like that).

asmeurer commented 6 years ago

Fixed by https://github.com/drdoctr/doctr/pull/318