search

drdoctr / doctr

A tool for automatically deploying docs from Travis CI to GitHub pages.
https://drdoctr.github.io
MIT License
107 stars 30 forks source link

Unable to restrict deploy on tags only #329

Closed guillaumekln closed 5 years ago

guillaumekln commented 5 years ago

Hi,

Is there a known regression regarding the combination --build-tags --branch-whitelist?

It seems I can't get it to work, the documentation is still deployed for new commits on master. Here is the command line I have in .travis.yml:

doctr deploy --build-tags --branch-whitelist --built-docs docs/build .

Thanks.

asmeurer commented 5 years ago

That definitely should work. It's the same as the command that is documented at https://drdoctr.github.io/recipes.html.

I thought I had thoroughly tested this, but the logic from a2a60827 seems wrong.

asmeurer commented 5 years ago

Potential fix at https://github.com/drdoctr/doctr/pull/330. I need to test it, though.

guillaumekln commented 5 years ago

Hi,

Any update on this?

asmeurer commented 5 years ago

Sorry, I haven't had a chance to look at doctr stuff in a while. Can you manually install from my branch from #330 and test that it works?

guillaumekln commented 5 years ago

Thanks for the update!

I pinned your latest commit in my Travis configuration, but it seems it is still pushing from master. Is that possible?

install:
  - pip install git+git://github.com/drdoctr/doctr@1d7153975c9299fa066f896af6927d31f9907fdd
script:
  - set -e
  - sphinx-build docs docs/build
  - doctr deploy --build-tags --branch-whitelist --built-docs docs/build .
asmeurer commented 5 years ago

Can you link me to the travis build

guillaumekln commented 5 years ago

Here is the build:

https://travis-ci.org/OpenNMT/OpenNMT-tf/jobs/460813114

asmeurer commented 5 years ago

Ah I missed some other logic that affects this. Not sure why it seemed to be working, though.

asmeurer commented 5 years ago

Ah the logic was still defaulting to master, so it only showed up after merging with master.