search

drdoctr / doctr

A tool for automatically deploying docs from Travis CI to GitHub pages.
https://drdoctr.github.io
MIT License
107 stars 30 forks source link

Fix branch-whitelist logic #330

Closed asmeurer closed 5 years ago

asmeurer commented 5 years ago

When --branch-whitelist is passed with no arguments, (i.e., it's empty), it should force the whitelist to be empty. Only when it is not passed at all should it default to {master}.

I haven't tested this yet.

Should fix #329.

asmeurer commented 5 years ago

Looks like the conda cryptography module is broken in Python 3.6.

asmeurer commented 5 years ago

Several old builds such as 1cecd1420767ea869b95d64e3b38ba23a81491fa were pushing from the empty --branch-whitelist build.

I pushed a commit to this branch that should force a deploy to verify that it doesn't do that anymore.

asmeurer commented 5 years ago

Now it doesn't push https://travis-ci.org/drdoctr/doctr/jobs/460406133#L3272. You can also see the tag- directory wasn't updated on gh-pages.